896756 - Fix strict warnings in xpcshell's head.js

Status: RESOLVED FIXED

(Testing :: XPCShell Harness, defect)

Description

[Mark Banner (:standard8)]

Attachment: Fix v1

There's a couple of strict warnings in head.js that are causing issues on comm-central. They are easy to fix with little risk, so we should just fix them.

Comment 2

[:aceman]

As said in bug 896906, the same appears in 
/mozilla/mobile/android/base/tests/robocop_head.js
    line 116 -- if (iid.Equals(Components.interfaces.nsITimerCallback) ||
    line 117 -- iid.Equals(Components.interfaces.nsISupports))

Comment 3

[Mark Banner (:standard8)]

Attachment: The fix v2

Including the android fix, switching reviewer as Ted's away.

Comment 4

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 779682 [details] [diff] [review]
The fix v2

Review of attachment 779682 [details] [diff] [review]:
-----------------------------------------------------------------

looks good to me.

Comment 5

[Mark Banner (:standard8)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3f2626641f86

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/3f2626641f86

Comment 7

[Mark Banner (:standard8)]

Comment on attachment 779682 [details] [diff] [review]
The fix v2

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 889911
User impact if declined: None
Testing completed (on m-c, etc.): landed on inbound
Risk to taking this patch (and alternatives if risky): none
String or IDL/UUID changes made by this patch: none

This regressed because bug 889911 was block-approved as part of another bug to land on aurora. Unfortunately, that causes Thunderbird many strict errors and warnings, which we are now tidying up. This patch tides up javascript strict errors in mozilla-central.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/4b9c49946fc3