896768 - Want to be able to style <textbox autocompletesearch="file"> results

Status: RESOLVED FIXED

(Toolkit :: Autocomplete, enhancement)

Description

[[e-mail]]

SeaMonkey and DOM Inspector have autocomplete textboxes that complete from both history and (on Linux only) local files. History autocomplete provides favicons, however local autocomplete provides no autocomplete images or styles.

One option is to make the nsFileResult's GetImageAt return a -moz-icon for the file, this would affect all the consumers (XUL filepicker for Linux included).

Another option is to make the nsFileResult's GetStyleAt return two values (such as "directory" and "file", as per nsFileView::GetCellProperties). Consumers would have to provide their own styles if desired (in filepicker.css for the XUL filepicker).

Comment 1

[[e-mail]]

Attachment: Possible patch

The filepicker.css changes are only for demonstration purposes unless you think that they are a good idea.

As a reminder the XUL filepicker is only available on Linux by setting the ui.allow_platform_file_picker preference to false.

Comment 2

[Dave Townsend [:mossop]]

Comment on attachment 779483 [details] [diff] [review]
Possible patch

Review of attachment 779483 [details] [diff] [review]:
-----------------------------------------------------------------

Is this something we can easily test?

Comment 3

[[e-mail]]

Attachment: XPCShellTest

This is the best I could come up with. The fifth test fails without the patch. Unfortunately I don't know an easy way of predicting the filesystem layout.

Comment 4

[[e-mail]]

https://tbpl.mozilla.org/?tree=Try&rev=8572e12d55cb tests without patch (all failed)
https://tbpl.mozilla.org/?tree=Try&rev=412b37833a1a tests with patch (random orange)

Comment 5

[Dave Townsend [:mossop]]

(In reply to [e-mail] from comment #3)
> Created attachment 780848 [details] [diff] [review]
> XPCShellTest
> 
> This is the best I could come up with. The fifth test fails without the
> patch. Unfortunately I don't know an easy way of predicting the filesystem
> layout.

Can't we create a directory in the temporary profile and load it up with a predictable filesystem?

Comment 6

[Dave Townsend [:mossop]]

Comment on attachment 780848 [details] [diff] [review]
XPCShellTest

Review of attachment 780848 [details] [diff] [review]:
-----------------------------------------------------------------

Waiting on a reply to my last question.

Comment 7

[[e-mail]]

Attachment: XPCShellTest

Comment 8

[[e-mail]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/cf1c3a76352d
https://hg.mozilla.org/integration/mozilla-inbound/rev/f3e583c68088

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/cf1c3a76352d
https://hg.mozilla.org/mozilla-central/rev/f3e583c68088