Closed
Bug 896811
Opened 12 years ago
Closed 12 years ago
Test output looks very strange, and is useless for failing tests
Categories
(Add-on SDK Graveyard :: General, defect, P1)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla26
People
(Reporter: evold, Assigned: dcamp)
Details
Attachments
(1 file)
909 bytes,
patch
|
jwalker
:
review+
|
Details | Diff | Splinter Review |
I'm getting stuff like this:
`console.info: pathfinder: pass:, css is unregistered.`
The `console.info:` stuff is not useful.
The `pass:,` is just strange.. why is there a `,` char?
Comment 1•12 years ago
|
||
I've been seeing odd tracebacks too. Is this related to switching away from using a file for output Irakli?
Flags: needinfo?(rFobic)
Comment 2•12 years ago
|
||
No it's related to switching to devtools console I believe, probably because they print stack traces differently then we did.
Flags: needinfo?(rFobic)
Reporter | ||
Comment 3•12 years ago
|
||
This stuff is really killing my productivity..
console.info: pathfinder: executing 'pathfinder/tests/test-storage.testSetThenGet'
console.error: pathfinder:
fail:
An error occured
console.trace: pathfinder:
_ecated/unit-test.js 89 _
_/sdk/test/assert.js 74 _
_sts/test-storage.js 21 _
_sdk/core/promise.js 137 _
_sdk/core/promise.js 56 _
_sdk/core/promise.js 189 _
_sdk/core/promise.js 212 _
_nder/lib/storage.js 81 _
_modules/NetUtil.jsm 85
0
console.log: pathfinder: 2222
console.error: pathfinder:
fail:
the data returned from get is correct 0.04738361818771386 - "0.04738361818771386" == ""
console.trace: pathfinder:
_ecated/unit-test.js 89 _
_/sdk/test/assert.js 89 _
_/sdk/test/assert.js 125 _
_sts/test-storage.js 23 _
_sdk/core/promise.js 122 _
_sdk/core/promise.js 122 _
_sdk/core/promise.js 47 _
_sdk/core/promise.js 157 _
_sdk/core/promise.js 189 _
_sdk/core/promise.js 122 _
_sdk/core/promise.js 47 _
_sdk/core/promise.js 189 _
_sdk/core/promise.js 137 _
_sdk/core/promise.js 56 _
_sdk/core/promise.js 189 _
_sdk/core/promise.js 212 _
_nder/lib/storage.js 81 _
_modules/NetUtil.jsm 85
0
console.error: pathfinder:
fail:
An error occured
console.trace: pathfinder:
_ecated/unit-test.js 89 _
_/sdk/test/assert.js 74 _
_sts/test-storage.js 27 _
_sdk/core/promise.js 137 _
_sdk/core/promise.js 56 _
_sdk/core/promise.js 189 _
_sdk/core/promise.js 131 _
_sdk/core/promise.js 47 _
_sdk/core/promise.js 189 _
_sdk/core/promise.js 122 _
_sdk/core/promise.js 122 _
_sdk/core/promise.js 47 _
_sdk/core/promise.js 157 _
_sdk/core/promise.js 189 _
_sdk/core/promise.js 122 _
_sdk/core/promise.js 47 _
_sdk/core/promise.js 189 _
_sdk/core/promise.js 137 _
_sdk/core/promise.js 56 _
_sdk/core/promise.js 189 _
_sdk/core/promise.js 212 _
_nder/lib/storage.js 81 _
_modules/NetUtil.jsm 85
0
Comment 4•12 years ago
|
||
Do you want to look into what is causing it then?
Assignee: nobody → evold
Priority: -- → P1
Reporter | ||
Updated•12 years ago
|
Summary: Test output looks very strange → Test output looks very strange, and is useless for failing tests
Reporter | ||
Comment 5•12 years ago
|
||
How did this get assigned to me? I'm busy enough, let's just revert the commit Irakli is referring to, I don't know who landed it or where.
Irakli do you know?
Assignee: evold → nobody
Flags: needinfo?(rFobic)
Comment 6•12 years ago
|
||
He's talking about bug 850296 I think and while we could back that out for a time we still need someone to figure out what the problem is and how to fix it. I assigned it to you because you were the one complaining about it. Everyone is busy.
Comment 7•12 years ago
|
||
I'm not actually seeing this problem anyway, are you testing on a recent Nightly of Firefox?
Updated•12 years ago
|
Assignee: nobody → dcamp
Assignee | ||
Comment 8•12 years ago
|
||
Proving that positional optional arguments are sad, max length comes before min length for this particular call.
Attachment #786513 -
Flags: review?(jwalker)
Comment 9•12 years ago
|
||
> (In reply to Erik Vold [:erikvold] [:ztatic] from comment #5)
> How did this get assigned to me? I'm busy enough, let's just revert the
> commit Irakli is referring to, I don't know who landed it or where.
>
> Irakli do you know?
It was Jordan, but looks like Dave is on it, so I'm not sure it's worth reverting it now.
Flags: needinfo?(rFobic)
Updated•12 years ago
|
Attachment #786513 -
Flags: review?(jwalker) → review+
Assignee | ||
Comment 10•12 years ago
|
||
Whiteboard: [fixed-in-fx-team]
Comment 11•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → mozilla26
Comment 12•12 years ago
|
||
(In reply to Erik Vold [:erikvold] [:ztatic] from comment #12)
> I'm getting stuff like this:
>
> `console.info: pathfinder: pass:, css is unregistered.`
>
> The `console.info:` stuff is not useful.
>
> The `pass:,` is just strange.. why is there a `,` char?
The comma should be fixed per bug 880752 (which I just relanded, including some modifications in the expectations of jetpack tests).
You need to log in
before you can comment on or make changes to this bug.
Description
•