Closed Bug 896911 Opened 12 years ago Closed 11 years ago

Rename "Resend" item to "Edit and Resend"

Categories

(DevTools :: Netmonitor, defect, P3)

Product:
DevTools
Component:
Netmonitor
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Firefox 26

People

(Reporter: harth, Assigned: reznord)

Details

(Whiteboard: [good first bug][mentor=fayearthur@gmail.com][lang=xul])

Attachments

(1 file, 2 obsolete files)

changes made and verified.
2.72 KB, patch
harth
: review+
Details | Diff | Splinter Review
"Edit and Replay" or "Edit and Resend" is more descriptive of what happens, so the context menu item should reflect it. That would be too much text for the button on the headers, so we should keep that text to "Resend" or "Replay".
Priority: -- → P3
I'm marking this as a good first bug!
Whiteboard: [good first bug][mentor=fayearthur@gmail.com][lang=xul]
Hi, I am willing to fix this bug. So, please I request you to assign this bug to me. Thanks in Advance, Regards, A. Anup
(In reply to Anup Allamsetty from comment #3) > Hi, > > I am willing to fix this bug. So, please I request you to assign this bug to > me. Sure.
Assignee: nobody → allamsetty.anup
Status: NEW → ASSIGNED
Attachment #789061 - Flags: review?(syshagarwal)
Attachment #789061 - Flags: review?(fayearthur)
Flags: needinfo?(fayearthur)
Attachment #789061 - Flags: review?(syshagarwal)
Comment on attachment 789061 [details] [diff] [review] In this I have changed the text according to the bug. Review of attachment 789061 [details] [diff] [review]: ----------------------------------------------------------------- There are two places where this appears, the button on the Headers tab, and the right-click context menu of a request. The text on the button should read "Replay", if we're going with that. You need to make a new string for "Edit and Replay" for the context menu, like "netmonitorUI.context.editAndReplay".
Attachment #789061 - Attachment is obsolete: true
Attachment #789061 - Flags: review?(fayearthur)
Attachment #790429 - Flags: review?(fayearthur)
Getting this error when I open the Network Panel: "XML Parsing Error: undefined entity Location: chrome://browser/content/devtools/netmonitor.xul Line Number 27, Column 7:" Can you try the patch out before uploading again?
Summary: Rename "Resend" item to "Edit and Replay" → Rename "Resend" item to "Edit and Resend"
are we supposed to edit the access.keys also in the netmonitor.xul file?
Attachment #790429 - Attachment is obsolete: true
Attachment #790429 - Flags: review?(fayearthur)
Attachment #790900 - Flags: review?(fayearthur)
Comment on attachment 790900 [details] [diff] [review] changes made and verified. Perfect, thanks for the patch.
Attachment #790900 - Flags: review?(fayearthur) → review+
https://hg.mozilla.org/integration/fx-team/rev/38dbe545e3d7
Whiteboard: [good first bug][mentor=fayearthur@gmail.com][lang=xul] → [good first bug][mentor=fayearthur@gmail.com][lang=xul][fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/38dbe545e3d7
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [good first bug][mentor=fayearthur@gmail.com][lang=xul][fixed-in-fx-team] → [good first bug][mentor=fayearthur@gmail.com][lang=xul]
Target Milestone: --- → Firefox 26
Thanks for the help regerding this bug. I would like to work on more bugs. If there are anymore bugs which you are mentoring please forward me the link. I will try fixing those bugs. Thanks in Advance, Regards, A. Anup
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: