896920 - B2G Emulator: support conference call

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[Hsin-Yi Tsai (she/her) (REO Fx 129) [:hsinyi]]

Multiparty state isn't correctly handled in telephony/android_modem.c. Some work is needed to make emulator work as expected.

Comment 1

[Hsin-Yi Tsai (she/her) (REO Fx 129) [:hsinyi]]

Attachment: PR to external_qemu

Comment 2

[Vicamo Yang [:vicamo][:vyang]]

Comment on attachment 791151 [details]
PR to external_qemu

Looks like we need another revision before landing.  Commented on GitHub.

Comment 3

[Hsin-Yi Tsai (she/her) (REO Fx 129) [:hsinyi]]

Attachment: PR to hardware_ril

Comment 4

[Hsin-Yi Tsai (she/her) (REO Fx 129) [:hsinyi]]

Comment on attachment 791151 [details]
PR to external_qemu

Review comments have been addressed. Please see those on github. Thanks.

Comment 5

[Vicamo Yang [:vicamo][:vyang]]

Comment on attachment 791151 [details]
PR to external_qemu

Looks good to me. But I'll check again tomorrow morning. Kind of late now. zzzZZZ

Comment 6

[Vicamo Yang [:vicamo][:vyang]]

ICS:
https://github.com/mozilla-b2g/platform_external_qemu/commit/e804997a08c1cc85b0f5dbcdfa7d40e57269c91e
https://github.com/mozilla-b2g/platform_hardware_ril/commit/02f428bf4c343aa1af3b9fb964d0653dfca11622

JB:
https://github.com/mozilla-b2g/platform_external_qemu/commit/7ffc039a5068b4dfe992bd0f6e962292984f2e68
https://github.com/mozilla-b2g/platform_hardware_ril/commit/1f488f96c6afdd9b0e0555228b3f25a719071d90