897013 - Style editor should use utils.getAllStyleSheets(document) to get all stylesheets

Status: RESOLVED WORKSFORME

(DevTools :: Style Editor, defect)

Description

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

The style editor should use utils.getAllStyleSheets(document) to get all stylesheets for a document. We currently try to get them all but are often missing a few and this API has been created for this purpose.

Please note that getAllStyleSheets() also returns chrome stylesheets so if devtools.chrome.enabled is set to true we should probably include them as well.

Comment 1

[Joe Walker [:jwalker]]

This is DOMUtils.getAllStyleSheets, right?

What specific cases does the style editor (StyleSheetsActor.getStyleSheets) get wrong?

DOMUtils.getAllStyleSheets on the other hand

* doesn't give you sheets imported using @import
* just duplicates sheets that are imported twice (which may be what you want, it depends)
* gives you chrome stylesheets (which may not be what you want) and doesn't make it easy to work out which is which

Comment 2

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

(In reply to Joe Walker [:jwalker] from comment #1)
> This is DOMUtils.getAllStyleSheets, right?
> 
> What specific cases does the style editor (StyleSheetsActor.getStyleSheets)
> get wrong?
> 
> DOMUtils.getAllStyleSheets on the other hand
> 
> * doesn't give you sheets imported using @import
> * just duplicates sheets that are imported twice (which may be what you
> want, it depends)
> * gives you chrome stylesheets (which may not be what you want) and doesn't
> make it easy to work out which is which

Agreed, we were randomly missing stylesheets when this bug was logged but discovery is running smoothly these days.