89702 - [outliner] double clicking toggles open state, cause problems for folder pane / thread pane / select folder dialog

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[esther]

Using builds 2001-06-07 on win, mac and linux, if you have your thread pane
sorted by thread and have a thread expanded, if you double-click on the 1st
thread to view in a stand alone window, the thread collapses.  

1. Launch Mail
2. Sort your Thread pane by thread and expand a thread.
3. Double-click on the 1st thread to bring up the msg in a stand alone window

result: the thread for that message collapses in the tread pane
expected: the thread to stay expanded

Comment 1

[kmurray1115]

putterman: let's get this on the radar for an upcoming release. Setting to 0.9.4
- if you disagree, please feel free to comment.

Comment 2

[scottputterman]

Seth, this looks the same or similar to a bug you fixed last week regarding
double clicking on the twisty.

Comment 3

[(not reading, please use [e-mail] instead)]

no, this is a seperate bug.

double clicking on a message that is the 1st message in a thread is toggling the
expand / collapse state of the message.

Comment 4

[(not reading, please use [e-mail] instead)]

I think the problem is coming from outliner.xml

in the double click handler, we have this:

if (!cycler && obj.value != "twisty" && b.view.isContainer(row.value))
  b.view.toggleOpenState(row.value);

for mailnews, we don't want double clicking to toggle the twisty state.

maybe this was added for outliners (bookmarks? filepicker? ftp?)

hyatt, I can leave this as the default and add a call to get a specific
attribute on the outlinerbody, and if that attribute is set to true, not toggle
on double click.

comments?

Comment 5

[(not reading, please use [e-mail] instead)]

hyatt gave me the info on how to do this.  I need use addEventListener() to 
override this behaviour.

Comment 6

[(not reading, please use [e-mail] instead)]

ok, thanks to hyatt and jan I've got this fixed for the thread pane and the 
folder pane in my local tree. I'll land it along with the fix for #73865.

I'm using addEventListener() and event.preventBubble().

Comment 7

[(not reading, please use [e-mail] instead)]

my fix for this has some weird side-effects.

I'll probably land 73865 with out it, and fix this problem afterwards.

Comment 8

[(not reading, please use [e-mail] instead)]

ok, the side effects weren't related.  I'll land the fix for this with the fix
for #73865.

Comment 9

[Jesse Ruderman]

*** Bug 94861 has been marked as a duplicate of this bug. ***

Comment 10

[Jesse Ruderman]

*** Bug 94997 has been marked as a duplicate of this bug. ***

Comment 11

[(not reading, please use [e-mail] instead)]

fixed.

for the folder pane, double clicking on a server should toggle the open / 
closed state, and should not open a new 3 pane.  double clicking on a folder 
should not toggle the open / closed state, it should open a new 3 pane.

for the thread pane, double clicking on a message in threaded mode should not 
toggle the open / closed state.

Comment 12

[Ninoschka Baca]

Build 2001-08-15-04: WinMe
Build 2001-08-15-08: Mac 9.04, Linux RH 6.2
Verified Fixed.

Comment 13

[kmurray1115]

This doesn't seem to be fixed for me on 2001-08-24-03. Win2K.

Comment 14

[John Morrison]

With 2001-08-24-03 on Win2K, I get exactly the response to a double click 
that Seth outlines above.

Comment 15

[kmurray1115]

I'm not. I'm selecting a message at the top level of a thread that is expanded,
double-clicking to open in a standalone message window, and seeing the thread
collapse before the standalone message window spawns. That's the behavior we
need to fix.