897268 - Need finalized artwork for Bookmarks Menu button

Status: RESOLVED FIXED

(Firefox :: Theme, defect)

Description

[Marco Bonardo [:mak]]

I am using placeholders for the dropdown button graphic in bug 855805, we need proper icons.

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Screenshot of current icons

Is this a valid bug anymore? The bookmark star and menu icon doesn't look crappy to me.

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

At its current state, this isn't a P1. Dropping this down to a P4 since it doesn't seem like many users will complain right away about it, and it shouldn't stop us from merging in to m-c.

Comment 3

[Jordan]

I think it looks pretty bad.  The screenshot you attached looks a bit better than what is currently on osx though.

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

(In reply to Jordan from comment #3)
> I think it looks pretty bad.  The screenshot you attached looks a bit better
> than what is currently on osx though.

OK, thanks. I just checked and I agree it looks worse on OSX.

Comment 5

[Marco Bonardo [:mak]]

(In reply to Jared Wein [:jaws] from comment #4)
> OK, thanks. I just checked and I agree it looks worse on OSX.

regardless, the images have been quickly edited as placeholders, not intended to be released at all, we need the hands of a graphic designer here.

Comment 6

[:Gijs (out for now; he/him)]

Icanhasicons? :-)

Comment 7

[Tim Nguyen :ntim]

(In reply to :Gijs Kruitbosch from comment #6)
> Icanhasicons? :-)

For Windows 8 : https://people.mozilla.org/~shorlander/mockups-interactive/australis-interactive-mockups/images-win8/toolbarButton-bookmarkPanel.png :)

Comment 8

[Robert Kaiser]

IMHO, this now ends up as being something that we probably should track on bug 939862. The current icon is very easy to confuse with the "Hamburger" menu button, which in the default set is even pretty near to it.
I already find it somewhat of a mental effort to get used to the "Hamburger" button, having something almost next to it that looks almost the same is definitely distracting and making it harder to learn the new UI.

Comment 9

[:Gijs (out for now; he/him)]

(In reply to Robert Kaiser (:[e-mail]) from comment #8)
> IMHO, this now ends up as being something that we probably should track on
> bug 939862. The current icon is very easy to confuse with the "Hamburger"
> menu button, which in the default set is even pretty near to it.
> I already find it somewhat of a mental effort to get used to the "Hamburger"
> button, having something almost next to it that looks almost the same is
> definitely distracting and making it harder to learn the new UI.

This doesn't make any sense. Bug australis-merge is specifically about issues which were discovered once we merged. We've always known this was an issue, ever since implementing this, but no new artwork has been provided so it's still the same. Making it block that bug won't increase the priority, which is already very high.

Comment 10

[Robert Kaiser]

OK, I just wanted to make sure we address this because I think it will make the transition easier (or at least it would for me).

Comment 11

[Michael Maslaney [:mmaslaney] ([e-mail])]

Would you like the glyph delivered solo or added to all toolbar.png sprites?

Comment 12

[Matthew N. [:MattN]]

(In reply to mmaslaney from comment #11)
> Would you like the glyph delivered solo or added to all toolbar.png sprites?

I believe we can replace the existing placeholder icon in Toolbar.png

Comment 13

[Michael Maslaney [:mmaslaney] ([e-mail])]

Attachment: fx_Toolbar.zip

Is Linux using the OS X toolbar?

Comment 14

[Matthew N. [:MattN]]

(In reply to mmaslaney from comment #13)
> Created attachment 8346223 [details]
> fx_Toolbar.zip
> 
> Is Linux using the OS X toolbar?

Linux and Windows seem to be the same. OS X is different. See images below:
* Linux:   https://mxr.mozilla.org/mozilla-central/source/browser/themes/linux/Toolbar.png
* Windows: https://mxr.mozilla.org/mozilla-central/source/browser/themes/windows/Toolbar.png
* OS X:    https://mxr.mozilla.org/mozilla-central/source/browser/themes/osx/Toolbar.png

Comment 15

[Michael Maslaney [:mmaslaney] ([e-mail])]

OK, great. Wanted to make sure we're covered for Linux assets. Thank you.

Comment 16

[Tim Nguyen :ntim]

(In reply to mmaslaney from comment #15)
> OK, great. Wanted to make sure we're covered for Linux assets. Thank you.

I think win aero is different from win XP assets, just to clarify, the assets that are the same as Linux are the XP while the one in the zip file is win7

Comment 17

[:Gijs (out for now; he/him)]

(In reply to Tim Nguyen [:ntim] from comment #16)
> (In reply to mmaslaney from comment #15)
> > OK, great. Wanted to make sure we're covered for Linux assets. Thank you.
> 
> I think win aero is different from win XP assets, just to clarify, the
> assets that are the same as Linux are the XP while the one in the zip file
> is win7

AFAICT there are folders for all of winXP/win7/win8 in the zip file, with corresponding images.

Comment 18

[Dão Gottwald [:dao]]

(In reply to Matthew N. [:MattN] from comment #14)
> (In reply to mmaslaney from comment #13)
> > Created attachment 8346223 [details]
> > fx_Toolbar.zip
> > 
> > Is Linux using the OS X toolbar?
> 
> Linux and Windows seem to be the same.

That's a bug. Linux shouldn't use the XP-style colored icons. The current Toolbar.png is basically a placeholder.

Comment 19

[Tim Nguyen :ntim]

(In reply to :Gijs Kruitbosch (Extremely limited availability until Dec. 18, then PTO until January 2) from comment #17)
> (In reply to Tim Nguyen [:ntim] from comment #16)
> > (In reply to mmaslaney from comment #15)
> > > OK, great. Wanted to make sure we're covered for Linux assets. Thank you.
> > 
> > I think win aero is different from win XP assets, just to clarify, the
> > assets that are the same as Linux are the XP while the one in the zip file
> > is win7
> 
> AFAICT there are folders for all of winXP/win7/win8 in the zip file, with
> corresponding images.

Oh sorry, I haven't noticed the XP assets.

(In reply to Dão Gottwald [:dao] from comment #18)
> (In reply to Matthew N. [:MattN] from comment #14)
> > (In reply to mmaslaney from comment #13)
> > > Created attachment 8346223 [details]
> > > fx_Toolbar.zip
> > > 
> > > Is Linux using the OS X toolbar?
> > 
> > Linux and Windows seem to be the same.
> 
> That's a bug. Linux shouldn't use the XP-style colored icons. The current
> Toolbar.png is basically a placeholder.

You're probably right. Stephen's new mockups introduce black icons.

Comment 21

[Peter Retzer (:pretzer)]

(In reply to Dão Gottwald [:dao] from comment #18)
> That's a bug. Linux shouldn't use the XP-style colored icons. The current
> Toolbar.png is basically a placeholder.

Will that bug be fixed here or in a new bug? If that's happening in a new bug, is there anything else blocking the work here? (except the holidays of course!) ;-)

Comment 22

[:Gijs (out for now; he/him)]

(In reply to Peter Retzer (:pretzer) from comment #21)
> (In reply to Dão Gottwald [:dao] from comment #18)
> > That's a bug. Linux shouldn't use the XP-style colored icons. The current
> > Toolbar.png is basically a placeholder.
> 
> Will that bug be fixed here or in a new bug? If that's happening in a new
> bug, is there anything else blocking the work here? (except the holidays of
> course!) ;-)

A new bug, and no, we just need to stick the new assets in the tree. I'll see if I have time to pick this up today.

Comment 23

[:Gijs (out for now; he/him)]

Attachment: need finalized artwork for Australis Bookmarks Menu,

So this does the right thing for this particular button on OS X. Fixing the star button to not get highlighted is more involved so I didn't want to do it in this bug, because it already happens, and I couldn't even remember for sure if it was by design or not.

Comment 24

[Mike de Boer [:mikedeboer]]

Comment on attachment 8355238 [details] [diff] [review]
need finalized artwork for Australis Bookmarks Menu,

Review of attachment 8355238 [details] [diff] [review]:
-----------------------------------------------------------------

First, apologies for the late review!

Since Linux uses the Windows icons, can you add that to this patch?

A question that does not relate to this bug directly: I noticed that icons for Windows 8 are specifically included in the zip file... shall I take it to bug 859751?

Comment 25

[Mike de Boer [:mikedeboer]]

Comment on attachment 8355238 [details] [diff] [review]
need finalized artwork for Australis Bookmarks Menu,

Review of attachment 8355238 [details] [diff] [review]:
-----------------------------------------------------------------

I don't know if the images were compressed the same way as the images that are currently in the repo, but the image sizes differ quite a bit for an addition of 'just' one icon. Especially the file sizes on OSX differ quite substantially.

I will take the Win8 glyphs and add them in bug 859751.

Comment 26

[:Gijs (out for now; he/him)]

(In reply to Mike de Boer [:mikedeboer] from comment #25)
> Comment on attachment 8355238 [details] [diff] [review]
> need finalized artwork for Australis Bookmarks Menu,
> 
> Review of attachment 8355238 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> I don't know if the images were compressed the same way as the images that
> are currently in the repo, but the image sizes differ quite a bit for an
> addition of 'just' one icon. Especially the file sizes on OSX differ quite
> substantially.

Well-spotted! Stephen told me he normally puts his through ImageOptim, so I did the same before committing this (and saved an average of 17.6%, apparently):

remote:   https://hg.mozilla.org/integration/fx-team/rev/ac385aa66e48

Comment 27

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/ac385aa66e48