Closed
Bug 897274
Opened 11 years ago
Closed 11 years ago
[fig] Hardware search button does not properly launch editing mode
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 26
People
(Reporter: Margaret, Assigned: sriram)
References
Details
(Whiteboard: abouthome-hackathon, fixed-fig)
Attachments
(1 file)
|
1.49 KB,
patch
|
Margaret
:
review+
|
Details | Diff | Splinter Review |
If you hit the hardware search button on a phone that has one, the keyboard comes up, but nothing else happens. Reproduced on a Nexus S and a DroidX.
|
Reporter | |
Updated•11 years ago
|
Assignee: nobody → margaret.leibovic
|
Assignee | |
Comment 1•11 years ago
|
||
Removed that piece of code that's not needed. I believe the earlier versions had the search button opening AwesomeBar in editing mode. If we did clean up the url-bar, I can add a patch to support that behavior through "startEditing()".
Attachment #780605 -
Flags: review?(margaret.leibovic)
|
|
Reporter | |
Comment 2•11 years ago
|
||
Comment on attachment 780605 [details] [diff] [review] Patch Nice catch. When I tested this, it did open the urlbar in editing mode, which seems like what we want.
Attachment #780605 -
Flags: review?(margaret.leibovic) → review+
|
|
Reporter | |
Updated•11 years ago
|
Assignee: margaret.leibovic → sriram
|
|
Assignee | |
Comment 3•11 years ago
|
||
http://hg.mozilla.org/projects/fig/file/38acbf12849e
Whiteboard: abouthome-hackathon → abouthome-hackathon, fixed-fig
|
||
Comment 4•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/38acbf12849e
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 26
|
||
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•