Closed Bug 897274 Opened 11 years ago Closed 10 years ago

[fig] Hardware search button does not properly launch editing mode

Categories

(Firefox for Android Graveyard :: General, defect)

Product:
Firefox for Android Graveyard
Component:
General
Platform:
ARM
Android
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Firefox 26

People

(Reporter: Margaret, Assigned: sriram)

References

Details

(Whiteboard: abouthome-hackathon, fixed-fig)

Attachments

(1 file)

Patch
1.49 KB, patch
Margaret
: review+
Details | Diff | Splinter Review 
If you hit the hardware search button on a phone that has one, the keyboard comes up, but nothing else happens. Reproduced on a Nexus S and a DroidX.
Assignee: nobody → margaret.leibovic
Attached patch Patch — — Splinter Review 
Removed that piece of code that's not needed.
I believe the earlier versions had the search button opening AwesomeBar in editing mode. If we did clean up the url-bar, I can add a patch to support that behavior through "startEditing()".
Attachment #780605 - Flags: review?(margaret.leibovic)
Comment on attachment 780605 [details] [diff] [review]
Patch

Nice catch.

When I tested this, it did open the urlbar in editing mode, which seems like what we want.
Attachment #780605 - Flags: review?(margaret.leibovic) → review+
Assignee: margaret.leibovic → sriram
http://hg.mozilla.org/projects/fig/file/38acbf12849e
Whiteboard: abouthome-hackathon → abouthome-hackathon, fixed-fig
https://hg.mozilla.org/mozilla-central/rev/38acbf12849e
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 26
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.