897327 - Projects with soundcloud and youtube not playing

Status: VERIFIED FIXED

(Webmaker Graveyard :: Popcorn Maker, defect)

Description

[Brett Gaylor [:brett]]

I cannot get this makes that use soundclouds to play at all
https://karmicangel.makes.org/popcorn/19in

Firefox 22 + Chrome 28.0.1500.71

Comment 1

[Brett Gaylor [:brett]]

So I was actually able to get this to load, though wildly out of sync.

Opening in the editor the clip plays fine.

The sync is off with the other two clips, but if I play the sequence from the start it seems to play as intended.

Comment 2

[Chris DeCairos (:cade)]

In firefox 23 I see:

[09:22:43.215] Blocked loading mixed active content "http://api.soundcloud.com/resolve?url=https%3A%2F%2Fsoundcloud.com%2Fkarmicangel%2Fannouncement-from-cbs-of&client_id=PRaNFlda6Bhf5utPjUsptg&format=json&_status_code_map[302]=200" @ https://connect.soundcloud.com/sdk.js:1

In my console. TL;DR; Mized content being blocked

Comment 3

[Chris DeCairos (:cade)]

*Mixed content*

Comment 4

[Brett Gaylor [:brett]]

I'm Firefox 22 and don't see that mixed content warning.  This seems to be about whether the clip is ready or not.

Comment 5

[Brett Gaylor [:brett]]

OK, I found STR:

1) remix https://karmicangel.makes.org/popcorn/19in
2) Delete two youtube clips that appear later in the timeline
3) republish

plays fine

Comment 6

[Scott [:thecount] Downe]

I'll dig into this Friday. Making it my priority.

Definitely not mixed content issues. (it does have that, but that's a whole other issue)

The clip can play, if it is ready, but it has serious issues getting ready, and we seem to allow it to be playable when it is in fact still struggling. Causing it to not play at all, in the case of nothing being ready, or playing from the wrong position, in the case of only some being ready.

More video's like YouTube just cause it to take even longer to get ready.

It seems to always play from the last buffered point closest to the seek target, instead of waiting.

Example, if I seek to 10 seconds, and only 3 is done, it seeks to 3 instead of buffering 10 and seeking to there.

Their UI and player do not do this, so I am confident there is a solution out there.

Comment 7

[Jon Buckley [:jbuck]]

It shouldn't have any mixed content issues, SoundCloud just fixed that bug.

Comment 8

[Scott [:thecount] Downe]

Attachment: https://github.com/mozilla/popcorn.webmaker.org/pull/135

Ha, just hit me as to what's wrong, soo simple, but not obvious because of similar issues in soundcloud that I thought I solved. So I kept looking there.

The actual problem/solution: We have a waiting param which is true if we have any currently active clips loading.

We also have a loading param for if ANY clip is loading, active or not.

I was checking against all loading clips if we need to replay a clip, but I only needed to check against active clips.

It was thinking about those STRs and it just clicked. I was also able to hit these STRs without soundcloud.

Comment 9

[Matthew Schranz [:mjschranz]]

The code looks good to me, but the STRs to reproduce it locally are somewhat confusing.

Scott, can you help me clear that up?

Comment 10

[Scott [:thecount] Downe]

STRs:

1. remake this locally: https://popcorn.webmaker.org/editor/59179/edit
2. hit play WHILE it is still loading.
3. wait for it to load.

Expected, it should start playing as soon as it is loaded.
Actual, it does not. It lost your play event.

You can also hit play after it loads and it likely does not play at all, because it is in a broken state.

Comment 11

[Matthew Schranz [:mjschranz]]

Comment on attachment 780793 [details] [review]
https://github.com/mozilla/popcorn.webmaker.org/pull/135

This doesn't seem to quite work in Chrome.

Building off your STRs:

1) Hitting the play button while it's loading isn't triggering a play to occur once it's ready.
2) If I hit play twice fast, it usually starts playing but without sound like the bug describes.

Comment 12

[Scott [:thecount] Downe]

Comment on attachment 780793 [details] [review]
https://github.com/mozilla/popcorn.webmaker.org/pull/135

Chrome is nt going to be able to take advantage of this fix.

bug 895058 has a bit of info on why, but I still don't quite get it.

Chrome in a lot of cases, and like I said I don't quite get why, doesn't return proper buffer data, just nonsense.

Can we push this fix through just for firefox for now?

You can test it without soundcloud in chrome, maybe that'll expose the bug and fix? Right, this isn't limited to soundcloud, so try it without.

Comment 13

[Scott [:thecount] Downe]

To follow through with what I was saying before, here is a project not using soundcloud: https://popcorn.webmaker.org/editor/59179/edit

Same issue, and my fix should now work in chrome.

Comment 14

[Scott [:thecount] Downe]

Staged: https://github.com/mozilla/popcorn.webmaker.org/commit/4c59191bf2edddcc81f04cbac6338993233a8716

Needs verification.

Comment 15

[Scott [:thecount] Downe]

I'm getting better results on master with this problem reproduced in a reduced project.

In a more complex project however, it comes back. bug 893777 should fix that, so I'll wait until bug 893777 lands before I'll double check and mark this as verified.