Add telemetry for the duration of the first restoreWindow() call that restores a session

RESOLVED FIXED in Firefox 25

Status

()

Firefox
Session Restore
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: ttaubert, Assigned: smacleod)

Tracking

(Blocks: 1 bug)

Trunk
Firefox 25
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

4 years ago
Before attacking bug 816607 we should add some telemetry that makes it possible to actually measure improvements. We should wrap this restoreWindow() call here:

http://mxr.mozilla.org/mozilla-central/source/browser/components/sessionstore/src/SessionStore.jsm#785

If we just record timestamps before and after the call we can easily see how much time it takes to create the tabs one after one, pinning and hidding them, reflowing, etc. On my machine this takes >1600ms for a 150+ tabs session.
(Reporter)

Comment 1

4 years ago
Steven, as you'll be working on bug 816607, want to take this one as well?
(Assignee)

Updated

4 years ago
Assignee: nobody → smacleod
(Assignee)

Updated

4 years ago
Status: NEW → ASSIGNED
(Assignee)

Comment 2

4 years ago
Created attachment 782876 [details] [diff] [review]
Patch - Add telemetry to restoreWindow

Instead of wrapping the call to |restoreWindow|, we time inside it and do not include the JSON parsing, call to onLoad, or the RestoreCompletedNotifications. This gives a better idea of how much time is being spent actually preforming the restore.
Attachment #782876 - Flags: review?(ttaubert)
(Reporter)

Comment 3

4 years ago
Comment on attachment 782876 [details] [diff] [review]
Patch - Add telemetry to restoreWindow

Review of attachment 782876 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!
Attachment #782876 - Flags: review?(ttaubert) → review+
(Assignee)

Updated

4 years ago
Keywords: checkin-needed
(Reporter)

Comment 4

4 years ago
https://hg.mozilla.org/integration/fx-team/rev/673fab39681d
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/673fab39681d
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 25
You need to log in before you can comment on or make changes to this bug.