Closed Bug 897396 Opened 7 years ago Closed 7 years ago

Add telemetry for the duration of the first restoreWindow() call that restores a session

Categories

(Firefox :: Session Restore, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 25

People

(Reporter: ttaubert, Assigned: smacleod)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Before attacking bug 816607 we should add some telemetry that makes it possible to actually measure improvements. We should wrap this restoreWindow() call here:

http://mxr.mozilla.org/mozilla-central/source/browser/components/sessionstore/src/SessionStore.jsm#785

If we just record timestamps before and after the call we can easily see how much time it takes to create the tabs one after one, pinning and hidding them, reflowing, etc. On my machine this takes >1600ms for a 150+ tabs session.
Steven, as you'll be working on bug 816607, want to take this one as well?
Assignee: nobody → smacleod
Status: NEW → ASSIGNED
Instead of wrapping the call to |restoreWindow|, we time inside it and do not include the JSON parsing, call to onLoad, or the RestoreCompletedNotifications. This gives a better idea of how much time is being spent actually preforming the restore.
Attachment #782876 - Flags: review?(ttaubert)
Comment on attachment 782876 [details] [diff] [review]
Patch - Add telemetry to restoreWindow

Review of attachment 782876 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!
Attachment #782876 - Flags: review?(ttaubert) → review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/673fab39681d
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 25
You need to log in before you can comment on or make changes to this bug.