Last Comment Bug 897396 - Add telemetry for the duration of the first restoreWindow() call that restores a session
: Add telemetry for the duration of the first restoreWindow() call that restore...
Status: RESOLVED FIXED
:
Product: Firefox
Classification: Client Software
Component: Session Restore (show other bugs)
: Trunk
: All All
: -- normal (vote)
: Firefox 25
Assigned To: Steven MacLeod [:smacleod]
:
:
Mentors:
Depends on:
Blocks: 816607
  Show dependency treegraph
 
Reported: 2013-07-24 01:43 PDT by Tim Taubert [:ttaubert]
Modified: 2013-07-30 15:56 PDT (History)
4 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch - Add telemetry to restoreWindow (3.00 KB, patch)
2013-07-29 17:23 PDT, Steven MacLeod [:smacleod]
ttaubert: review+
Details | Diff | Splinter Review

Description Tim Taubert [:ttaubert] 2013-07-24 01:43:52 PDT
Before attacking bug 816607 we should add some telemetry that makes it possible to actually measure improvements. We should wrap this restoreWindow() call here:

http://mxr.mozilla.org/mozilla-central/source/browser/components/sessionstore/src/SessionStore.jsm#785

If we just record timestamps before and after the call we can easily see how much time it takes to create the tabs one after one, pinning and hidding them, reflowing, etc. On my machine this takes >1600ms for a 150+ tabs session.
Comment 1 Tim Taubert [:ttaubert] 2013-07-24 01:44:39 PDT
Steven, as you'll be working on bug 816607, want to take this one as well?
Comment 2 Steven MacLeod [:smacleod] 2013-07-29 17:23:48 PDT
Created attachment 782876 [details] [diff] [review]
Patch - Add telemetry to restoreWindow

Instead of wrapping the call to |restoreWindow|, we time inside it and do not include the JSON parsing, call to onLoad, or the RestoreCompletedNotifications. This gives a better idea of how much time is being spent actually preforming the restore.
Comment 3 Tim Taubert [:ttaubert] 2013-07-29 18:18:11 PDT
Comment on attachment 782876 [details] [diff] [review]
Patch - Add telemetry to restoreWindow

Review of attachment 782876 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!
Comment 4 Tim Taubert [:ttaubert] 2013-07-30 09:43:03 PDT
https://hg.mozilla.org/integration/fx-team/rev/673fab39681d
Comment 5 Ryan VanderMeulen [:RyanVM] 2013-07-30 12:44:04 PDT
https://hg.mozilla.org/mozilla-central/rev/673fab39681d

Note You need to log in before you can comment on or make changes to this bug.