Closed Bug 897408 Opened 11 years ago Closed 11 years ago

Erroneous style.removeProperty call in Site.prototype.refreshThumbnail (browser/base/content/newtab/sites.js)

Categories

(Firefox :: General, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 26

People

(Reporter: dao, Assigned: markh)

References

Details

Attachments

(1 file)

>+  refreshThumbnail: function Site_refreshThumbnail() {
>     let thumbnailURL = PageThumbs.getThumbnailURL(this.url);
>     let thumbnail = this._querySelector(".newtab-thumbnail");
>+    // if this is being called due to the thumbnail being updated we will
>+    // be setting it to the same value it had before.  To be confident the
>+    // change wont be optimized away we remove the property first.
>+    thumbnail.style.removeProperty("backgroundImage");

I bet this doesn't work, because it should be "background-image". Maybe this line isn't needed after all? Or it's needed and the effect you tried to prevent is still there...
yep - my bad - and note I added this after Tim's review.
Assignee: nobody → mhammond
Given the remoteProperty call is obviously wrong, the fact no-one has complained about them not updating, and testing shows they do update (notwithstanding what I said in bug 870100 comment 32), we might as well just remove it.
Attachment #784763 - Flags: review?(ttaubert)
Attachment #784763 - Flags: review?(ttaubert) → review+
https://hg.mozilla.org/mozilla-central/rev/40529527fa04
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 26
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: