897512 - add support for proxies to the persona extension

Status: RESOLVED FIXED

(bugzilla.mozilla.org Graveyard :: Extensions: Persona, defect)

Description

[:glob ✱]

add support for proxies to the persona extension because very soon bmo will need to use a proxy to communicate with the persona servers.

Comment 1

[:glob ✱]

Committing to: bzr+ssh://[e-mail]/bmo/4.2/
modified extensions/Persona/lib/Config.pm
modified extensions/Persona/lib/Login.pm
modified extensions/Persona/template/en/default/admin/params/persona.html.tmpl
Committed revision 8892.

Comment 2

[Shyam Mani [:fox2mike]]

Not just persona, everything that bugzilla needs to speak to on the outside world on 80 or 443 will have to go through the proxies...I just want to make sure we have an option for that.

Comment 3

[Gervase Markham [:gerv]]

Perhaps attaching a patch would be conventional? :-)

Gerv

Comment 4

[Gervase Markham [:gerv]]

Also, I've had trouble using LWP::UserAgent's built-in proxy support and HTTPS together. You are sure this works, right? :-)

Gerv

Comment 5

[:glob ✱]

(In reply to Shyam Mani [:fox2mike] from comment #2)
> Not just persona, everything that bugzilla needs to speak to on the outside
> world on 80 or 443 will have to go through the proxies...I just want to make
> sure we have an option for that.

bug 897851

(In reply to Gervase Markham [:gerv] from comment #3)
> Perhaps attaching a patch would be conventional? :-)

for trivial changes like we don't attach a patch.

(In reply to Gervase Markham [:gerv] from comment #4)
> Also, I've had trouble using LWP::UserAgent's built-in proxy support and
> HTTPS together. You are sure this works, right? :-)

yes, like all changes i tested this patch prior to committing it, and again after committing it on our staging environment.  i'm sure it works in our environment.