Closed Bug 897561 Opened 6 years ago Closed 6 years ago

Bump target SDK to 16

Categories

(Firefox for Android :: General, defect)

All
Android
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 25
Tracking Status
firefox24 --- unaffected
firefox25 --- fixed

People

(Reporter: stully, Assigned: stully)

Details

Attachments

(1 file, 1 obsolete file)

Assignee: nobody → stully
Attachment #780753 - Flags: review?(cpeterson)
Comment on attachment 780753 [details] [diff] [review]
bump-target-sdk.diff

Review of attachment 780753 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM. You should send an email to mobile-firefox-dev@mozilla.org warning people about that change.
Attachment #780753 - Flags: review?(cpeterson) → review+
Attached patch bump-target-sdk.diff (obsolete) — Splinter Review
Changed new target SDK to 18 at the request of sriram.
Attachment #780753 - Attachment is obsolete: true
Attachment #781126 - Flags: review?(cpeterson)
Comment on attachment 781126 [details] [diff] [review]
bump-target-sdk.diff

Review of attachment 781126 [details] [diff] [review]:
-----------------------------------------------------------------

I don't think we should increase our target SDK version to 18 if we are not using new APIs from 17 or 18. Most developers probably have SDK 16 or 17 already installed, so no one should complain about a target version bump to 16.
Attachment #781126 - Flags: review?(cpeterson) → review-
Comment on attachment 780753 [details] [diff] [review]
bump-target-sdk.diff

Unobsolete SDK 16 patch
Attachment #780753 - Attachment is obsolete: false
Attachment #781126 - Attachment is obsolete: true
https://hg.mozilla.org/mozilla-central/rev/ad41d146f657
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 25
You need to log in before you can comment on or make changes to this bug.