Closed
Bug 897574
Opened 12 years ago
Closed 12 years ago
GC: fix the GGC opt build
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla25
People
(Reporter: terrence, Assigned: terrence)
References
Details
Attachments
(1 file)
|
3.26 KB,
patch
|
sfink
:
review+
|
Details | Diff | Splinter Review |
Cell::isTenured is debug-only, so we need a different way to do this. Since I've already pulled a nursery reference into the store buffer for bug 889682, I think the right solution here is to just pull that hunk out and use Nursery::isInside.
Attachment #780502 -
Flags: review?(sphink)
|
||
Comment 1•12 years ago
|
||
Comment on attachment 780502 [details] [diff] [review]
fix_ggc_opt_build-v0.diff
Review of attachment 780502 [details] [diff] [review]:
-----------------------------------------------------------------
Works for me. It doesn't seem awful for the store buffer to know about the nursery. (Unless you're secretly cooking up plans to have multiple nurseries or something. Keep all the noisy babies in one room or something.)
Attachment #780502 -
Flags: review?(sphink) → review+
|
Assignee | |
Comment 2•12 years ago
|
||
|
||
Comment 3•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
You need to log in
before you can comment on or make changes to this bug.
Description
•