897596 - Defect - Grid in snapped view display top sites and bookmarks in vertical columns

Status: VERIFIED FIXED

(Firefox for Metro Graveyard :: Firefox Start, defect, P2)

Description

[Jim Mathies [:jimm]]

Attachment: Screenshot (59).png

See screenshot, off latest tip. I think this is supposed to be more of a collapsing single column.

Comment 1

[Rodrigo Silveira [:rsilveira] [:rodms]]

Attachment: Patch v1

Patch https://hg.mozilla.org/integration/mozilla-inbound/rev/28e87c73927d for bug 885242 overwrote all my changes in browser.css. Adding them back.

Comment 2

[Sam Foster [:sfoster] (he/him)]

Comment on attachment 780674 [details] [diff] [review]
Patch v1

Review of attachment 780674 [details] [diff] [review]:
-----------------------------------------------------------------

I knew I didn't imagine seeing this working.

::: browser/metro/theme/browser.css
@@ +195,5 @@
>    display: -moz-box;
>  }
>  
>  #start-scrollbox[input="precise"] {
>    overflow-x: scroll;

Great minds think alike, I just made the same change in a local patch. I'll add yours to my queue

Comment 3

[Rodrigo Silveira [:rsilveira] [:rodms]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/750c29cf4f8f

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/750c29cf4f8f

Comment 5

[Manuela Muntean [Away]]

Attachment: screenshot_Nightly_2013-07-28

Mozilla/5.0 (Windows NT 6.2; rv:25.0) Gecko/20130728 Firefox/25.0

Verified as fixed on the latest Nightly build. In snapped view, top sites and bookmarks are collapsed in a single column.

Please see the attached screenshot for details.

Comment 6

[Manuela Muntean [Away]]

> Verified as fixed on the latest Nightly build. In snapped view, top sites
> and bookmarks are collapsed in a single column.

Also verified on Win 8 64bit, on the latest Nightly, Mozilla/5.0 (Windows NT 6.2; Win64; x64; rv:25.0) Gecko/20130729 Firefox/25.0