Closed Bug 897830 Opened 6 years ago Closed 2 years ago

Work - Write more tests for MenuPopup prototype

Categories

(Firefox for Metro Graveyard :: Components, defect)

x86_64
Windows 8.1
defect
Not set

Tracking

(Not tracked)

RESOLVED INCOMPLETE

People

(Reporter: jwilde, Unassigned)

Details

(Whiteboard: [leave open])

Attachments

(1 file, 3 obsolete files)

There are two things called "flyouts" in Windows 8:
- Settings flyouts: those big panels that swoop in from the side for adjusting sync settings, showing about info, and the like.
- Flyouts: anything that looks remotely popup-menu-ish. When I refer to "flyouts", this is what I mean.

---

Over on my cupcake prototyping branch (https://github.com/hellojwilde/mozilla-central/commits/jwilde/cupcake-snippets), I've been building a new system for making flyouts. It mirrors a lot of our existing markup for menu popups, but is constructed in a somewhat cleaner and more robust manner than our existing MenuPopup prototype (no setTimeouts).

For a bunch of future planned UI things, having this XBL widget around will make life vastly easier. And, we should be able to eventually migrate menus over to running on it and have them be a lot more robust.

I think it'd be a good idea to:
- Rebrand the settings flyout code as flyoutpanel.
- Land the flyout XBL widget, along with some tests. No integration here with anything else. Just the widget. We can integrate it later when we have cleanup cycles.
Attachment #781237 - Attachment is obsolete: true
Attachment #781238 - Attachment is obsolete: true
Finally have something that's short, tidy, and cleanly applies in MQ.
Attachment #781405 - Attachment is obsolete: true
Attachment #781929 - Flags: review?(tabraldes)
Comment on attachment 781929 [details] [diff] [review]
part1 - rebrand flyout as flyoutpanel

Review of attachment 781929 [details] [diff] [review]:
-----------------------------------------------------------------

Seems simple enough. I assume you've tested that the flyouts still work and that the tests run?
Attachment #781929 - Flags: review?(tabraldes) → review+
(In reply to Tim Abraldes [:TimAbraldes] [:tabraldes] from comment #5)
> Comment on attachment 781929 [details] [diff] [review]
> part1 - rebrand flyout as flyoutpanel
> 
> Review of attachment 781929 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Seems simple enough. I assume you've tested that the flyouts still work and
> that the tests run?

Yup! (Except for intermittent oranges on the context menu tests, which the later patches in this series could actually provide a basis for cleaning up.)
Status: NEW → ASSIGNED
Whiteboard: [leave open]
Right now, it's not clear that adding more XBL to the menus will necessarily help things, and most of the important bits needed to reduce intermittent oranges have been moved into the MenuPopup already, so morphing this bug.
Summary: Work - Write tests for and land new unified flyout system → Work - Write more tests for MenuPopup prototype
Assignee: jwilde → nobody
OS: Windows 8 Metro → Windows 8.1
Mass close of bugs in obsolete product https://bugzilla.mozilla.org/show_bug.cgi?id=1350354
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → INCOMPLETE
You need to log in before you can comment on or make changes to this bug.