Work - Write more tests for MenuPopup prototype

RESOLVED INCOMPLETE

Status

Firefox for Metro
Components
RESOLVED INCOMPLETE
4 years ago
3 months ago

People

(Reporter: jwilde, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [leave open])

Attachments

(1 attachment, 3 obsolete attachments)

(Reporter)

Description

4 years ago
There are two things called "flyouts" in Windows 8:
- Settings flyouts: those big panels that swoop in from the side for adjusting sync settings, showing about info, and the like.
- Flyouts: anything that looks remotely popup-menu-ish. When I refer to "flyouts", this is what I mean.

---

Over on my cupcake prototyping branch (https://github.com/hellojwilde/mozilla-central/commits/jwilde/cupcake-snippets), I've been building a new system for making flyouts. It mirrors a lot of our existing markup for menu popups, but is constructed in a somewhat cleaner and more robust manner than our existing MenuPopup prototype (no setTimeouts).

For a bunch of future planned UI things, having this XBL widget around will make life vastly easier. And, we should be able to eventually migrate menus over to running on it and have them be a lot more robust.

I think it'd be a good idea to:
- Rebrand the settings flyout code as flyoutpanel.
- Land the flyout XBL widget, along with some tests. No integration here with anything else. Just the widget. We can integrate it later when we have cleanup cycles.
(Reporter)

Comment 1

4 years ago
Created attachment 781237 [details] [diff] [review]
part1 - rebrand flyout as flyoutpanel
(Reporter)

Comment 2

4 years ago
Created attachment 781238 [details] [diff] [review]
part1 - rebrand flyout as flyoutpanel
Attachment #781237 - Attachment is obsolete: true
(Reporter)

Comment 3

4 years ago
Created attachment 781405 [details] [diff] [review]
part1 - rebrand flyout as flyoutpanel
Attachment #781238 - Attachment is obsolete: true
(Reporter)

Comment 4

4 years ago
Created attachment 781929 [details] [diff] [review]
part1 - rebrand flyout as flyoutpanel

Finally have something that's short, tidy, and cleanly applies in MQ.
Attachment #781405 - Attachment is obsolete: true
(Reporter)

Updated

4 years ago
Attachment #781929 - Flags: review?(tabraldes)
Comment on attachment 781929 [details] [diff] [review]
part1 - rebrand flyout as flyoutpanel

Review of attachment 781929 [details] [diff] [review]:
-----------------------------------------------------------------

Seems simple enough. I assume you've tested that the flyouts still work and that the tests run?
Attachment #781929 - Flags: review?(tabraldes) → review+
(Reporter)

Comment 6

4 years ago
(In reply to Tim Abraldes [:TimAbraldes] [:tabraldes] from comment #5)
> Comment on attachment 781929 [details] [diff] [review]
> part1 - rebrand flyout as flyoutpanel
> 
> Review of attachment 781929 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Seems simple enough. I assume you've tested that the flyouts still work and
> that the tests run?

Yup! (Except for intermittent oranges on the context menu tests, which the later patches in this series could actually provide a basis for cleaning up.)
Status: NEW → ASSIGNED
(Reporter)

Updated

4 years ago
Whiteboard: [leave open]
(Reporter)

Comment 7

4 years ago
Part 1: https://hg.mozilla.org/integration/mozilla-inbound/rev/94eeed0da711
https://hg.mozilla.org/mozilla-central/rev/94eeed0da711
(Reporter)

Comment 9

4 years ago
Right now, it's not clear that adding more XBL to the menus will necessarily help things, and most of the important bits needed to reduce intermittent oranges have been moved into the MenuPopup already, so morphing this bug.
Summary: Work - Write tests for and land new unified flyout system → Work - Write more tests for MenuPopup prototype
(Reporter)

Updated

4 years ago
Assignee: jwilde → nobody
(Assignee)

Updated

3 years ago
OS: Windows 8 Metro → Windows 8.1
Mass close of bugs in obsolete product https://bugzilla.mozilla.org/show_bug.cgi?id=1350354
Status: ASSIGNED → RESOLVED
Last Resolved: 3 months ago
Resolution: --- → INCOMPLETE
You need to log in before you can comment on or make changes to this bug.