897885 - Handle kVK_JIS_KeypadComma

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, defect)

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.1 Handle kVK_JIS_KeypadComma in widget::TextInputHandler

This is just a mistake. We don't handle comma key on numpad of JIS keyboard for Mac.

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.2 Add test for handling kVK_JIS_KeypadComma

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://tbpl.mozilla.org/?tree=Try&usebuildbot=1&rev=5433d17f40b8

Comment 4

[Steven Michaud [:smichaud] (Retired)]

Comment on attachment 780972 [details] [diff] [review]
part.1 Handle kVK_JIS_KeypadComma in widget::TextInputHandler

This looks fine to me, at least in principle.

But I have no way of testing this, and am (basically) just taking your word for it, Masayuki, that this is correct :-)

Comment 5

[Steven Michaud [:smichaud] (Retired)]

Comment on attachment 780973 [details] [diff] [review]
part.2 Add test for handling kVK_JIS_KeypadComma

By the way, sorry that I took so long to review.

This slipped through the cracks.

Comment 6

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a91a01ef61cb
https://hg.mozilla.org/integration/mozilla-inbound/rev/432fc41b95a1

> But I have no way of testing this,

Me neither for non-Japanese Mac keyboard and non-US Mac keyboard. I'd like Apple to buy all keyboard on any countries' Apple store.

> By the way, sorry that I took so long to review.

No problem, I forgot this too :-)

Comment 7

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/a91a01ef61cb
https://hg.mozilla.org/mozilla-central/rev/432fc41b95a1