897890 - [mozprocess] mozprocess behaves incorrectly when stdout is redirected

Status: RESOLVED INCOMPLETE

(Testing :: Mozbase, defect)

Description

[nodeless]

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:22.0) Gecko/20100101 Firefox/22.0 (Beta/Release)
Build ID: 20130618035212

Steps to reproduce:

If stdout is redirected, the process immediately closes on Linux (On windows, an exception is raised in the processOutput thread). processOutput() depends on stdout being a pipe.

Comment 1

[nodeless]

Attachment: 0001-Modify-processOutput-to-behave-correctly-when-stdout.patch

I'm moving jetpack to the latest mozbase (bug 897370) and encountered the above because jetpack redirects stdout and stderr. I've reworked the logic to fix this bug, and have added test cases for all of the bugs I found. The tests pass on win7 and Debian.

Full details are in the commit message.

Comment 2

[nodeless]

Note that this patch is built on top of the two other patches I've submitted: 892917 and 892902.

Comment 3

[Dave Townsend [:mossop]]

Is this patch ready for review? Who can review it?

Comment 4

[Andrew Halberstadt [:ahal]]

Sorry this got lost in the ether. There have been a lot of mozprocess changes since this bug (recently bug 794984 just landed that re-writes most of the code this patch is touching) so this may have been fixed as a side effect. Can someone confirm if this is still happening, and if so provide more explicit STR?