897942 - [SMS] SMS contact lookup type(Home,Work,Mobile) always displayed in English for other languages also

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::SMS, defect, P2)

Description

[Leo]

1. Title: SMS contact lookup type(Home,Work,Mobile) always displayed in English for other languages also
2. Precondition: Add contact with different labels(Home,Work,Mobile)in contact application
3. Tester's Action: 1. Message -> New Message
                    2. In the recipient, type the first letter of the contact 
                    3. Check the Label name in the retrieved search list.
4. Detailed Symptom (ENG.) : The Label name (like Home,Mobile) in the serach list is shown in English
5. Expected:  All the Label names should be shown in the respective language
6. Reproducibility: Y
1) Frequency Rate : 100%
7. Gaia Master/v1-train: Reproduced on v1-train
8. Gaia Revision:  ff14001a72c18553dfa3b678eff06cf6bac83bdd
9. Personal email id: [e-mail]

Comment 1

[Leo]

Attachment: pointer to pull request

Hi Steve,
Please review the patch and provide your comments
Thanks,

Comment 2

[Rick Waldron [:rwaldron]]

Comments on patch: https://github.com/mozilla-b2g/gaia/pull/11165#issuecomment-21593516

Comment 3

[Steve Chung [:steveck]]

Attachment: Unit-test-for-bug-897942.patch

Since the fixing in the patch will use affect unit test, I fixed the unit test part and add more test cases for it.

Comment 4

[Steve Chung [:steveck]]

Attachment: pull-request.html

Hi Borja, I've merged the pr from leo with unit test. Could you please take a look? Thanks.

Comment 5

[Steve Chung [:steveck]]

Comment on attachment 783694 [details]
pull-request.html

Hi Corey, I've updated the patch. Thanks for the comments on github.

Comment 6

[Corey Frang [:gnarf]]

Comment on attachment 783694 [details]
pull-request.html

r=me

Comment 7

[Steve Chung [:steveck]]

Test case fixed and landed in master: 13a97bc7a88b5ef5e73f632bf59a5335f0fdae07

Comment 8

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted 13a97bc7a88b5ef5e73f632bf59a5335f0fdae07 to:
v1-train: a5bf2a72f9295b6a8d36446f09800e81071c2817

Comment 9

[Tim Guan-tin Chien [:timdream] (please needinfo)]

v1.1.0hd: a5bf2a72f9295b6a8d36446f09800e81071c2817

Comment 10

[Deepa Subramanian]

The user is able to see the Phone type localized in the respective languages. Issue is fixed for Polski, Ceština, Nederlanders, Pу́сский, ελληνικά, Slovenčina, Română, Brazilian Portuguese , Magyar, Deutsch,Spanish, Türkçe, Hrvatska, српски, Catalan, Srpski.

Verified for Leo V.1.1
Build ID: 20130813041202
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/36bbc5943448
Gaia: df57dcec720493bedff4601499d78c147ad7d253
Platform Version: 18.1