897945 - Use an XPCOM string for nsContentUtils::ReportToConsole's category argument

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Patch v1

Comment 1

[Bobby Holley (:bholley)]

Comment on attachment 780933 [details] [diff] [review]
Patch v1

Review of attachment 780933 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/base/public/nsContentUtils.h
@@ +804,5 @@
>                                    const nsAFlatString& aSourceLine
>                                      = EmptyString(),
>                                    uint32_t aLineNumber = 0,
>                                    uint32_t aColumnNumber = 0);
> +  template<uint32_t N>

I don't understand. Why does this need to be templatized?

Comment 2

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 780933 [details] [diff] [review]
Patch v1

Review of attachment 780933 [details] [diff] [review]:
-----------------------------------------------------------------

The templates allow passing a literal string, which is fine, and I didn't really want to add NS_LITERAL_CSTRING to every call.

Comment 3

[Bobby Holley (:bholley)]

Why can't that overload take a const char* instead?

Comment 4

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

This bug was prompted by someone passing the result of ToNewUTF8String there, so that's exactly what I want to avoid here.

Comment 5

[Bobby Holley (:bholley)]

Comment on attachment 780933 [details] [diff] [review]
Patch v1

Review of attachment 780933 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/base/public/nsContentUtils.h
@@ +805,5 @@
>                                      = EmptyString(),
>                                    uint32_t aLineNumber = 0,
>                                    uint32_t aColumnNumber = 0);
> +  template<uint32_t N>
> +  static nsresult ReportToConsole(uint32_t aErrorFlags,

Please add a comment explaining the trick and why we need the overload.

Comment 6

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/8a7a62729e5b