Closed
Bug 897967
Opened 11 years ago
Closed 11 years ago
FirefoxRunner should subclass LocalRunner, not Runner
Categories
(Testing :: Mozbase, defect)
Testing
Mozbase
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: ahal, Assigned: ahal)
References
Details
Attachments
(1 file)
|
3.03 KB,
patch
|
jgriffin
:
review+
|
Details | Diff | Splinter Review |
This is a regression from bug 870876. Basically I forgot to s/Runner/LocalRunner and unfortunately nothing in our unittests or in m-c caught it until we ran profileserver.
|
Assignee | |
Comment 1•11 years ago
|
||
Attachment #780970 -
Flags: review?(jgriffin)
|
||
Comment 2•11 years ago
|
||
Comment on attachment 780970 [details] [diff] [review] Patch 1.0 - subclass LocalRunner Review of attachment 780970 [details] [diff] [review]: ----------------------------------------------------------------- Yeah it's weird this didn't break anything else.
Attachment #780970 -
Flags: review?(jgriffin) → review+
|
|
Assignee | |
Comment 3•11 years ago
|
||
https://github.com/mozilla/mozbase/commit/5794e6b6801ee0359c0c87f802ac09b377cc2a56
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•