898056 - add definitions to graph server for tart

Status: RESOLVED FIXED

(Webtools Graveyard :: Graph Server, defect)

Description

[Joel Maher ( :jmaher ) (UTC -8) (PTO'ish until July 5)]

tart is a new talos test which has a custom pageset and will be reporting in the meantime to graph server.

Comment 1

[Joel Maher ( :jmaher ) (UTC -8) (PTO'ish until July 5)]

Attachment: add graph server definitions for tart (1.0)

Comment 2

[Joel Maher ( :jmaher ) (UTC -8) (PTO'ish until July 5)]

Attachment: add graph server definitions for tart (1.1)

wrong version of the patch

Comment 3

[Avi Halachmi (:avih)]

Comment on attachment 781102 [details] [diff] [review]
add graph server definitions for tart (1.1)

Review of attachment 781102 [details] [diff] [review]:
-----------------------------------------------------------------

::: sql/data.sql
@@ +4434,4 @@
>  insert into tests values (NULL,"tscrollx","tscroll, Frame Rate 10Khz",1,1,11);
>  insert into tests values (NULL,"tcanvasmark","CanvasMark",0,1,NULL);
>  insert into tests values (NULL,"tcanvasmark_nochrome","Canvasmark, NoChrome",0,1,NULL);
> +insert into tests values (NULL,"tart","Tab Animation Test",1,1,15);

I believe this should be 1,1,20. The last value is pageset_id, as appears at the tests table schema here: http://hg.mozilla.org/graphs/file/eb5d54f97e68/sql/schema.sql#l28 , and our pageset_id at pages_table.sql is 20.

r=me with this change.

Comment 4

[Joel Maher ( :jmaher ) (UTC -8) (PTO'ish until July 5)]

http://hg.mozilla.org/graphs/rev/d09b90498506

Comment 5

[Avi Halachmi (:avih)]

> +insert into tests values (NULL,"tart_nochrome","Tab Animation Test, NoChrome",1,1,20);

According to the schema linked from comment 3, the above line adds a definition for a test which is called "tart_nochrome", which is declared as chrome and active by the other values inserted to the table.

If it's a placeholder to smooth things out at places which I'm not familiar with, I'd have expected it to at least be "tart_nochrome",0,0,20. However, joel promises me this smooths things out, so I'd take his word for it.