Closed Bug 898056 Opened 7 years ago Closed 7 years ago

add definitions to graph server for tart

Categories

(Webtools Graveyard :: Graph Server, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: jmaher, Assigned: jmaher)

References

Details

Attachments

(1 file, 1 obsolete file)

tart is a new talos test which has a custom pageset and will be reporting in the meantime to graph server.
Assignee: nobody → jmaher
Status: NEW → ASSIGNED
Attachment #781093 - Flags: review?(avihpit)
wrong version of the patch
Attachment #781093 - Attachment is obsolete: true
Attachment #781093 - Flags: review?(avihpit)
Attachment #781102 - Flags: review?(avihpit)
Comment on attachment 781102 [details] [diff] [review]
add graph server definitions for tart (1.1)

Review of attachment 781102 [details] [diff] [review]:
-----------------------------------------------------------------

::: sql/data.sql
@@ +4434,4 @@
>  insert into tests values (NULL,"tscrollx","tscroll, Frame Rate 10Khz",1,1,11);
>  insert into tests values (NULL,"tcanvasmark","CanvasMark",0,1,NULL);
>  insert into tests values (NULL,"tcanvasmark_nochrome","Canvasmark, NoChrome",0,1,NULL);
> +insert into tests values (NULL,"tart","Tab Animation Test",1,1,15);

I believe this should be 1,1,20. The last value is pageset_id, as appears at the tests table schema here: http://hg.mozilla.org/graphs/file/eb5d54f97e68/sql/schema.sql#l28 , and our pageset_id at pages_table.sql is 20.

r=me with this change.
Attachment #781102 - Flags: review?(avihpit) → review+
http://hg.mozilla.org/graphs/rev/d09b90498506
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
> +insert into tests values (NULL,"tart_nochrome","Tab Animation Test, NoChrome",1,1,20);

According to the schema linked from comment 3, the above line adds a definition for a test which is called "tart_nochrome", which is declared as chrome and active by the other values inserted to the table.

If it's a placeholder to smooth things out at places which I'm not familiar with, I'd have expected it to at least be "tart_nochrome",0,0,20. However, joel promises me this smooths things out, so I'd take his word for it.
Blocks: 908690
Product: Webtools → Webtools Graveyard
You need to log in before you can comment on or make changes to this bug.