898061 - "Show all threads" duplicates the crashing thread

Status: VERIFIED FIXED

(Socorro :: Webapp, task)

Description

[Benjamin Smedberg]

I believe this is a regression from the django webapp. The default view shows the crashing thread, and there is a "show/hide other threads" link to show all the threads. But now, when you show all threads, the crashing thread is displayed twice, which is confusing.

The crashing thread should only be shown once.

See also bug 767067, which, if you're touching this code, it might be nice to fix at the same time.

Example crashing showing this issue: https://crash-stats.mozilla.com/report/index/d425559e-10a1-4e59-b78d-376ce2130725

Comment 1

[Peter Bengtsson [:peterbe]]

PR: https://github.com/mozilla/socorro/pull/1376 :rhelmer r?

Comment 2

[[github robot]]

Commit pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/5c1d47aa29f99424fce0f2e4003f0725d4b2f496
fixes bug 898061 - "Show all threads" duplicates the crashing thread, r=rhelmer

Comment 3

[Lonnen :lonnen]

Changes for this bug are going out in 56.

Comment 4

[Peter Bengtsson [:peterbe]]

Steps to reproduce:

1. Go to a report index page 
 e.g. https://crash-stats.allizom.org/report/index/872eee87-aec0-4c9e-800f-44b082130814
2. Scroll down a bit to the "Crash Thread" table (http://cl.ly/Qq8G)
3. Note that it's in that table
4. Scroll down to the bottom of that page and click "Show/hide other threads"
5. The first table that now appears should NOT be an identical copy of what's already been shown. (http://cl.ly/Qqah)

Comment 5

[Matt Brandt [:mbrandt]]

QA verified on stage - thanks for the most-excellent steps to verify :peterbe. I looked at reports for Firefox, Thunderbird, and b2g. These seem to be in order and do not show the duplication that is currently present on prod.