Closed
Bug 898095
Opened 12 years ago
Closed 12 years ago
Create a default thumbnail for x-ray goggles
Categories
(Webmaker Graveyard :: X-Ray Goggles, defect)
Webmaker Graveyard
X-Ray Goggles
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: brett, Assigned: cassie)
References
Details
Attachments
(1 file)
We need a simple default thumbnail, similar to what popcorn maker and the goggles have - maybe blue? Need this for discoverability in search and myMakes.
we have the defaults for thimble and popcorn linking through here, https://github.com/mozilla/webmaker.org/blob/master/public/css/style.less#L419-L434, so if we just repeat what we have there for goggles we should be good to go.
| Assignee | ||
Comment 3•12 years ago
|
||
so here's one that's grey/transparent: https://docs.google.com/file/d/0BzfN9sXlOXt1Ml9kZG4zaEVlR2s/edit?usp=sharing
and one that's solid colour - https://docs.google.com/file/d/0BzfN9sXlOXt1VDZaQ2JfallrVFE/edit?usp=sharing
Still wondering why there need to be two different thumbs. We should confirm these are the correct sizes as well (should look good on retina display too).
Attachment #785203 -
Flags: review?(cassie)
Attachment #785203 -
Flags: review?(cassie) → review?(gavin)
Comment 5•12 years ago
|
||
Comment on attachment 785203 [details] [review]
https://github.com/mozilla/webmaker.org/pull/314
Looks good!
Attachment #785203 -
Flags: review?(gavin) → review+
Comment 6•12 years ago
|
||
Commit pushed to master at https://github.com/mozilla/webmaker.org
https://github.com/mozilla/webmaker.org/commit/5af28d736da18049650f16b3d0d79c1b52651421
Merge pull request #314 from Pomax/bug898095
xray goggles make detail styling
Updated•12 years ago
|
Attachment mime type: text/plain → text/x-github-pull-request
You need to log in
before you can comment on or make changes to this bug.
Description
•