xpcshell make target should pass in pluginsPath

RESOLVED FIXED in mozilla25

Status

defect
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: mihneadb, Assigned: mihneadb)

Tracking

unspecified
mozilla25
x86_64
Linux
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

If you don't specify any plugins path to xpcshell, it will just assume bin/plugins, which is not the correct plugins path on local builds. The correct one is dist/plugins.

Mach specifies the plugins path and all works well. We need the make target to do this as well, for people who are still using it.
Blocks: 890098
Attachment #781262 - Flags: review?(gps)
Assignee: nobody → mihneadb
Comment on attachment 781262 [details] [diff] [review]
pass in plguins path

Review of attachment 781262 [details] [diff] [review]:
-----------------------------------------------------------------

This is fine by itself. Keep in mind that the automation configs (https://hg.mozilla.org/build/mozharness/) are separate from the in-tree configs. You may need to also modify them to pass in the plugins path. But from the sound of your initial comment on the bug, perhaps the default of bin/plugins is acceptable for packaged builds?
Attachment #781262 - Flags: review?(gps) → review+
(In reply to Gregory Szorc [:gps] from comment #2)
> Comment on attachment 781262 [details] [diff] [review]
> pass in plguins path
> 
> Review of attachment 781262 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> This is fine by itself. Keep in mind that the automation configs
> (https://hg.mozilla.org/build/mozharness/) are separate from the in-tree
> configs. You may need to also modify them to pass in the plugins path. But
> from the sound of your initial comment on the bug, perhaps the default of
> bin/plugins is acceptable for packaged builds?

Yes, everything is already set up (including xpcshell.cpp!) to be friends with bin/plugins.
https://hg.mozilla.org/mozilla-central/rev/60542f3605e3
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
You need to log in before you can comment on or make changes to this bug.