898234 - Wasted work in sctp_setopt()

Status: RESOLVED FIXED

(Core :: Networking, defect)

Description

[pchang9]

Attachment: Suggested patch

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:18.0) Gecko/20100101 Firefox/18.0 (Beta/Release)
Build ID: 20130116073211

Steps to reproduce:

The problem appears in changeset 138350:18467a85acf6. I have attached a simple one-line patch that fixes it.

In method sctp_setopt() in netwerk/sctp/src/netinet/sctp_usrreq.c, the loop on line 4755 should break immediately after "found" is set to "1". All the iterations after "found" is set to "1" do not perform any useful work, at best they just set "found" again to "1".



Expected results:

Break loop after "found" is set to "1".

Comment 1

[[:Aleksej]]

>In method sctp_setopt() in netwerk/sctp/src/netinet/sctp_usrreq.c, the loop on line 4755

https://hg.mozilla.org/mozilla-central/file/18467a85acf6/netwerk/sctp/src/netinet/sctp_usrreq.c#l4754

Comment 2

[Patrick McManus [:mcmanus]]

pchang9 - thanks.

I believe this is imported code and it would be better in this case to just work the patch directly with the upstream repo which we will eventually inherit. But Randell would know for sure and can provide any pointers.

Comment 3

[Randell Jesup [:jesup] (needinfo me)]

-> Tuexen to resolve in upstream (I see no need to land this before we pick it up from upstream).

Thanks pchang9!

Comment 4

[Michael Tüxen]

Fixed upstream in
http://code.google.com/p/sctp-refimpl/source/detail?r=8555
http://code.google.com/p/sctp-refimpl/source/detail?r=8556
The fix also cleans up the code a bit.

Thanks for bringing this up.

Best regards
Michael