Closed Bug 898267 Opened 6 years ago Closed 6 years ago

Azure CoreGraphics backend needs to support font smoothing

Categories

(Core :: Graphics: Text, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla25

People

(Reporter: jtd, Assigned: jtd)

References

Details

Attachments

(1 file)

Cairo Quartz code has the ability to set the CG font smoothing parameter, via the antialias font option:

http://mxr.mozilla.org/mozilla-central/source/gfx/cairo/cairo/src/cairo-quartz-font.c#704

The code in DrawTargetCG.cpp calls CGContextSetShouldAntialias but not
CGContextSetShouldSmoothFonts.

Not quite sure how the antialias parameter gets passed down but I'm guessing the code in gfxMacFont needs to explicitly set the mAntialiasOption within the logic here:

http://mxr.mozilla.org/mozilla-central/source/gfx/thebes/gfxMacFont.cpp#84
Set the mAntialiasOption member as needed and call CGContextSetShouldSmoothFonts within DrawTargetCG.cpp when drawing glyphs.
Attachment #781486 - Flags: review?(jmuizelaar)
Attachment #781486 - Flags: review?(jmuizelaar) → review+
Pushed to inbound:
https://hg.mozilla.org/integration/mozilla-inbound/rev/04a45dec4326
Target Milestone: --- → mozilla25
Landed on inbound again after reftest fix:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e2340b350694
https://hg.mozilla.org/mozilla-central/rev/e2340b350694
Assignee: nobody → jdaggett
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.