898267 - Azure CoreGraphics backend needs to support font smoothing

Status: RESOLVED FIXED

(Core :: Graphics: Text, defect)

Description

[John Daggett (:jtd)]

Cairo Quartz code has the ability to set the CG font smoothing parameter, via the antialias font option:

http://mxr.mozilla.org/mozilla-central/source/gfx/cairo/cairo/src/cairo-quartz-font.c#704

The code in DrawTargetCG.cpp calls CGContextSetShouldAntialias but not
CGContextSetShouldSmoothFonts.

Not quite sure how the antialias parameter gets passed down but I'm guessing the code in gfxMacFont needs to explicitly set the mAntialiasOption within the logic here:

http://mxr.mozilla.org/mozilla-central/source/gfx/thebes/gfxMacFont.cpp#84

Comment 1

[John Daggett (:jtd)]

Attachment: azure-font-smoothing.patch

Set the mAntialiasOption member as needed and call CGContextSetShouldSmoothFonts within DrawTargetCG.cpp when drawing glyphs.

Comment 2

[John Daggett (:jtd)]

Pushed to inbound:
https://hg.mozilla.org/integration/mozilla-inbound/rev/04a45dec4326

Comment 3

[Ed Morley [:emorley]]

Push backed out for reftest failures:
https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=c2f27bb078fd&jobname=reftest

remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/d79375a692fe
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/d97f10fc581c
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/1ce2e0435eca
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/8c89fe2a5c92

Comment 4

[John Daggett (:jtd)]

Landed on inbound again after reftest fix:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e2340b350694

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/e2340b350694