Closed Bug 898438 Opened 7 years ago Closed 7 years ago

nsITableEditor.getCellAt doesn't default to the current table

Categories

(Core :: DOM: Editor, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla25

People

(Reporter: neil, Assigned: neil)

References

Details

(Keywords: regression)

Attachments

(1 file)

Prior to bug 781409, nsITableEditor.getCellAt used to return a cell from the current table. Now it fails if you don't pass in a table. This means that the "Join with Cell to the Right" option in SeaMonkey Composer (and also present in Thunderbird Message Compose) has stopped working.
I also noticed that it always returns NS_OK but I don't think any of the callers currently minds which success code it does return.
Attached patch Proposed patchSplinter Review
Assignee: nobody → neil
Status: NEW → ASSIGNED
Attachment #781735 - Flags: review?(ehsan)
Comment on attachment 781735 [details] [diff] [review]
Proposed patch

Review of attachment 781735 [details] [diff] [review]:
-----------------------------------------------------------------

::: editor/libeditor/html/nsTableEditor.cpp
@@ +2760,5 @@
> +    NS_ENSURE_SUCCESS(res, res);
> +    if (table)
> +      aTable = table;
> +    else
> +      return NS_ERROR_FAILURE;

Nit: please use braces.
Attachment #781735 - Flags: review?(ehsan) → review+
https://hg.mozilla.org/mozilla-central/rev/1bb4b1eba285
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
You need to log in before you can comment on or make changes to this bug.