Closed
Bug 898438
Opened 12 years ago
Closed 12 years ago
nsITableEditor.getCellAt doesn't default to the current table
Categories
(Core :: DOM: Editor, defect)
Core
DOM: Editor
Tracking
()
RESOLVED
FIXED
mozilla25
People
(Reporter: neil, Assigned: neil)
References
Details
(Keywords: regression)
Attachments
(1 file)
|
1.05 KB,
patch
|
ehsan.akhgari
:
review+
|
Details | Diff | Splinter Review |
Prior to bug 781409, nsITableEditor.getCellAt used to return a cell from the current table. Now it fails if you don't pass in a table. This means that the "Join with Cell to the Right" option in SeaMonkey Composer (and also present in Thunderbird Message Compose) has stopped working.
|
Assignee | |
Comment 1•12 years ago
|
||
I also noticed that it always returns NS_OK but I don't think any of the callers currently minds which success code it does return.
|
|
Assignee | |
Comment 2•12 years ago
|
||
|
||
Comment 3•12 years ago
|
||
Comment on attachment 781735 [details] [diff] [review]
Proposed patch
Review of attachment 781735 [details] [diff] [review]:
-----------------------------------------------------------------
::: editor/libeditor/html/nsTableEditor.cpp
@@ +2760,5 @@
> + NS_ENSURE_SUCCESS(res, res);
> + if (table)
> + aTable = table;
> + else
> + return NS_ERROR_FAILURE;
Nit: please use braces.
Attachment #781735 -
Flags: review?(ehsan) → review+
|
|
Assignee | |
Comment 4•12 years ago
|
||
|
||
Comment 5•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
You need to log in
before you can comment on or make changes to this bug.
Description
•