898472 - Browser Debugger window has no title

Status: RESOLVED FIXED

(DevTools :: Debugger, defect, P3)

Description

[:Gijs (he/him)]

It would be nice if it said at least "Browser Debugger", possibly with the script name that's currently open.

Comment 1

[:Gijs (he/him)]

I guess this is a bigger issue on Windows, actually. Oops. Saw this on my XP VM, so moving there! :-)

Comment 2

[Sunny [:darkowlzz]]

Hi,
I would like to know if this bug appears only on Windows XP?
A screenshot would be of great help.

I don't have access to Windows and on Linux, the title appears to be just `Browser Debugger`. Is this bug about appending Browser Debugger's title with the opened file name?

Thanks!

Comment 3

[mjh563]

Attachment: Screenshot of Browser Debugger window

I can reproduce this on Linux too. See attached screenshot.

Comment 4

[Sunny [:darkowlzz]]

Attachment: Screenshot of Browser Debugger window - title visible in FF23.0.1

Comment 5

[mjh563]

So this regressed in Firefox 24. Running mozregression gives:

Last good nightly: 2013-06-21
First bad nightly: 2013-06-22

Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=7ba8c86f1a56&tochange=cea75ce9a559

Comment 6

[:Gijs (he/him)]

(In reply to mjh563 from comment #5)
> So this regressed in Firefox 24. Running mozregression gives:
> 
> Last good nightly: 2013-06-21
> First bad nightly: 2013-06-22
> 
> Pushlog:
> http://hg.mozilla.org/mozilla-central/
> pushloghtml?fromchange=7ba8c86f1a56&tochange=cea75ce9a559

http://hg.mozilla.org/mozilla-central/rev/9e0781b97e51#l11.62
http://hg.mozilla.org/mozilla-central/rev/9e0781b97e51#l32.32

Doesn't look like this document.title setting was put back anywhere else, and the strings disappeared. I'm guessing they'd need to be re-added, and so would the code that sets the right one.

Comment 7

[Victor Porof [:vporof][:vp]]

Yup. Just re-adding those strings should do the trick. However, I also like the idea suggested in comment 0.

Comment 8

[Sunny [:darkowlzz]]

Attachment: Added missing Title strings and appended with script name.

Comment 9

[Victor Porof [:vporof][:vp]]

Comment on attachment 807211 [details] [diff] [review]
Added missing Title strings and appended with script name.

Review of attachment 807211 [details] [diff] [review]:
-----------------------------------------------------------------

This looks great! Let me know if you need any help with adding a test. You can edit a pre-existing one to account for this change, e.g. browser_dbg_scripts-switching-01.js

Comment 10

[Brandon Benvie [:benvie]]

Comment on attachment 807211 [details] [diff] [review]
Added missing Title strings and appended with script name.

Review of attachment 807211 [details] [diff] [review]:
-----------------------------------------------------------------

Indeed, this looks excellent as is. Just needs a test. I'm also available if you need help writing one!

Comment 11

[Sunny [:darkowlzz]]

Attachment: Added missing Title strings and appended with script name.

With test!

Comment 12

[Brandon Benvie [:benvie]]

https://tbpl.mozilla.org/?tree=Try&rev=8e0a63eeb9b5

Comment 13

[Brandon Benvie [:benvie]]

Comment on attachment 815167 [details] [diff] [review]
Added missing Title strings and appended with script name.

Review of attachment 815167 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/devtools/debugger/test/browser_dbg_scripts-switching-01.js
@@ +19,5 @@
>      gEditor = gDebugger.DebuggerView.editor;
>      gSources = gDebugger.DebuggerView.Sources;
>  
> +    ok(gDebugger.document.title.endsWith(EXAMPLE_URL + gLabel1),
> +      "Title with first source is incorrect.");

Small nit: the message should state the expected result ("Title with first source is correct.")

@@ +67,5 @@
>    is(gEditor.getText().search(/debugger/), 172,
>      "The second source is displayed.");
>  
> +  ok(gDebugger.document.title.endsWith(EXAMPLE_URL + gLabel2),
> +    "Title with second source is incorrect.");

Same as above.

Comment 14

[Sunny [:darkowlzz]]

Attachment: Added missing Title strings and appended with script name.

Comment 15

[Victor Porof [:vporof][:vp]]

Comment on attachment 815171 [details] [diff] [review]
Added missing Title strings and appended with script name.

Review of attachment 815171 [details] [diff] [review]:
-----------------------------------------------------------------

Perfection.

Comment 16

[Brandon Benvie [:benvie]]

https://hg.mozilla.org/integration/fx-team/rev/f22b6a8bc244

Comment 17

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/f22b6a8bc244