898596 - video Play button overlay is horizontally squished (oval) in Nightly, in contrast to Fx22 (circle).

Status: RESOLVED DUPLICATE of bug 897787

(Core :: Layout, defect)

Description

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Attachment: Screen Shot 2013-07-26 at 3.39.40 PM.png

See attached image and link. Observed on OSX and Windows 7.

Comment 1

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Ehugg says he thinks the oval buttons on video play happened this week on Nightly, not sure which patch though.

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Can you run this through mozregression to find when this regressed? http://mozilla.github.io/mozregression/

Comment 3

[Ethan Hugg [:ehugg]]

I'm pretty sure this one is the culprit:

https://hg.mozilla.org/mozilla-central/rev/783e53214215
Bug 700926. Refactor image sizing to be closer to the spec and not tied to backgrounds. r=roc

I got these results:

Mon Jul 22 - 783e53214215 - Oval
Mon Jul 22 - 26ebafeabaf7 - Round

Comment 4

[Nick Cameron [:nrc]]

Possibly a dup of 897787, not sure how to find how the play button is constructed. I have a patch in the works, so I'll see if it fixes this too.

Comment 5

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Thanks Ethan (clearing needinfo)

Comment 6

[bhavana bajaj [:bajaj]]

Although a polish issue, tracking as this is a regression and looks ugly given how common the video play button overlay is used.

Comment 7

[Ethan Hugg [:ehugg]]

This appears fixed in M-C with the landing today of bug 897787, so marking as dupe.