Closed Bug 898646 Opened 6 years ago Closed 6 years ago

[FIG] Add focus selected graphics for Tabs on History Page

Categories

(Firefox for Android :: Theme and Visual Design, defect)

All
Android
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 26

People

(Reporter: shilpanbhagat, Assigned: sriram)

References

Details

Attachments

(1 file, 1 obsolete file)

Currently there is no graphics for focus selected on Tabs for the History Page. This would be useful for keyboard/joystick navigation.
What's the expected appearance for a focused tab in the History page?
Flags: needinfo?(ibarlow)
Like so: http://cl.ly/image/3B1z390O033d

Background colour: #cfd9e1 (same colour as urlbar bg)
Flags: needinfo?(ibarlow)
Hardware: ARM → All
Assignee: nobody → sriram
(In reply to Ian Barlow (:ibarlow) from comment #2)
> Like so: http://cl.ly/image/3B1z390O033d
> 
> Background colour: #cfd9e1 (same colour as urlbar bg)

We use #CED7DE for the url-bar. Did something go wrong? We don't use CFD9E1 anywhere.
Attached patch Patch (obsolete) — Splinter Review
Hocus pocus, here's the focus!
(Please check commit comments too ;) )
Attachment #796338 - Flags: review?(margaret.leibovic)
Comment on attachment 796338 [details] [diff] [review]
Patch

Are you missing a change to this file?
http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/resources/drawable-large-land-v11/home_history_tabs_indicator.xml

Also flagging Shilpan for review, since he's more familiar with this.
Attachment #796338 - Flags: review?(sbhagat)
Attached patch PatchSplinter Review
Done.
Attachment #796338 - Attachment is obsolete: true
Attachment #796338 - Flags: review?(sbhagat)
Attachment #796338 - Flags: review?(margaret.leibovic)
Attachment #796364 - Flags: review?(sbhagat)
Attachment #796364 - Flags: review?(margaret.leibovic)
Comment on attachment 796364 [details] [diff] [review]
Patch

Review of attachment 796364 [details] [diff] [review]:
-----------------------------------------------------------------

On phones, what about situations when the tab is selected and you press on it? We will loose the selected tab drawable right? Maybe we need a special drawable in these situations? LGTM otherwise.

Focus would probably be affected in a similar fashion.
Attachment #796364 - Flags: review?(sbhagat)
(In reply to Shilpan Bhagat from comment #7)
> Comment on attachment 796364 [details] [diff] [review]
> Patch
> 
> Review of attachment 796364 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> On phones, what about situations when the tab is selected and you press on
> it? We will loose the selected tab drawable right? Maybe we need a special
> drawable in these situations? LGTM otherwise.
> 
> Focus would probably be affected in a similar fashion.

I did that for the tab-bar in tabs-panel. He have focused+selected state there. This is a temporary patch for getting it working. We need to special case that, and it can be fixed later.
Comment on attachment 796364 [details] [diff] [review]
Patch

Review of attachment 796364 [details] [diff] [review]:
-----------------------------------------------------------------

Okay, maybe we should file another bug for that?
Attachment #796364 - Flags: review+
Comment on attachment 796364 [details] [diff] [review]
Patch

Review of attachment 796364 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for the review help, Shilpan!
Attachment #796364 - Flags: review?(margaret.leibovic) → review+
https://hg.mozilla.org/mozilla-central/rev/012934880e76
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 26
You need to log in before you can comment on or make changes to this bug.