898646 - [FIG] Add focus selected graphics for Tabs on History Page

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Theme and Visual Design, defect)

Description

[Shilpan Bhagat]

Currently there is no graphics for focus selected on Tabs for the History Page. This would be useful for keyboard/joystick navigation.

Comment 1

[Lucas Rocha (:lucasr)]

What's the expected appearance for a focused tab in the History page?

Comment 2

[Ian Barlow (:ibarlow)]

Like so: http://cl.ly/image/3B1z390O033d

Background colour: #cfd9e1 (same colour as urlbar bg)

Comment 3

[Sriram Ramasubramanian [:sriram]]

(In reply to Ian Barlow (:ibarlow) from comment #2)
> Like so: http://cl.ly/image/3B1z390O033d
> 
> Background colour: #cfd9e1 (same colour as urlbar bg)

We use #CED7DE for the url-bar. Did something go wrong? We don't use CFD9E1 anywhere.

Comment 4

[Sriram Ramasubramanian [:sriram]]

Attachment: Patch

Hocus pocus, here's the focus!
(Please check commit comments too ;) )

Comment 5

[:Margaret Leibovic]

Comment on attachment 796338 [details] [diff] [review]
Patch

Are you missing a change to this file?
http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/resources/drawable-large-land-v11/home_history_tabs_indicator.xml

Also flagging Shilpan for review, since he's more familiar with this.

Comment 6

[Sriram Ramasubramanian [:sriram]]

Attachment: Patch

Done.

Comment 7

[Shilpan Bhagat]

Comment on attachment 796364 [details] [diff] [review]
Patch

Review of attachment 796364 [details] [diff] [review]:
-----------------------------------------------------------------

On phones, what about situations when the tab is selected and you press on it? We will loose the selected tab drawable right? Maybe we need a special drawable in these situations? LGTM otherwise.

Focus would probably be affected in a similar fashion.

Comment 8

[Sriram Ramasubramanian [:sriram]]

(In reply to Shilpan Bhagat from comment #7)
> Comment on attachment 796364 [details] [diff] [review]
> Patch
> 
> Review of attachment 796364 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> On phones, what about situations when the tab is selected and you press on
> it? We will loose the selected tab drawable right? Maybe we need a special
> drawable in these situations? LGTM otherwise.
> 
> Focus would probably be affected in a similar fashion.

I did that for the tab-bar in tabs-panel. He have focused+selected state there. This is a temporary patch for getting it working. We need to special case that, and it can be fixed later.

Comment 9

[Shilpan Bhagat]

Comment on attachment 796364 [details] [diff] [review]
Patch

Review of attachment 796364 [details] [diff] [review]:
-----------------------------------------------------------------

Okay, maybe we should file another bug for that?

Comment 10

[:Margaret Leibovic]

Comment on attachment 796364 [details] [diff] [review]
Patch

Review of attachment 796364 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for the review help, Shilpan!

Comment 11

[Sriram Ramasubramanian [:sriram]]

https://hg.mozilla.org/integration/fx-team/rev/012934880e76

Comment 12

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/012934880e76