898693 - test_audioBufferSourceNodeNeutered.html times out when ran on a Firefox OS emulator

Status: RESOLVED FIXED

(Core :: Web Audio, defect)

Description

[Jason Smith [:jsmith]]

See the discussion on bug 896582.

content/media/webaudio/test/test_audioBufferSourceNodeNeutered.html appears to be timing out when ran on a Firefox OS emulator. We should find out why and try to get this test preffed on again in the b2g.json file.

Comment 1

[Martijn Wargers (dead)]

Ok, sorry, this is my fault, I think I know why I put this test file in b2g.json.
While working on bug 896582, I had to run the content/media mochitest often to look for time outs in tests. So to speed things up, I reduced the TestRunner.timeout to 60s (and increased the allowed amount of test timeouts):
http://mxr.mozilla.org/mozilla-central/source/testing/mochitest/tests/SimpleTest/TestRunner.js#84

This particular test file is taking appr. 60s to run, so I guess that's why I added it to the b2g.json file.
When I'm running it now in a b2g mochitest run, I don't see any failures at all, so I think this file can be safely removed from the b2g.json file (I also accidentally added it twice to the b2g.json file).

Comment 2

[Jason Smith [:jsmith]]

Attachment: Turn on test_audioBufferSourceNodeNeutered.html v1

Comment 3

[Jason Smith [:jsmith]]

Kicking off a try run to see if we can turn this on.

https://tbpl.mozilla.org/?tree=Try&rev=2aae0652fa8e

Comment 4

[Jason Smith [:jsmith]]

Comment on attachment 783226 [details] [diff] [review]
Turn on test_audioBufferSourceNodeNeutered.html v1

Try run is green.

Comment 5

[Martijn Wargers (dead)]

Comment on attachment 783226 [details] [diff] [review]
Turn on test_audioBufferSourceNodeNeutered.html v1

Review of attachment 783226 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks, I'm not sure I'm allowed to review something and that it then can be checked into the tree.
So asking jgriffin just to be sure (although since the tryserver is green, this is a no-brainer, I think)

Comment 6

[(no longer active)]

Comment on attachment 783226 [details] [diff] [review]
Turn on test_audioBufferSourceNodeNeutered.html v1

Nice!

Comment 7

[Jonathan Griffin (:jgriffin)]

Comment on attachment 783226 [details] [diff] [review]
Turn on test_audioBufferSourceNodeNeutered.html v1

Review of attachment 783226 [details] [diff] [review]:
-----------------------------------------------------------------

Cool.  Hopefully this won't be an intermittent orange, but let's see what happens!

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/projects/birch/rev/ae8af45ea23c

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/ae8af45ea23c