898701 - [Gallery] image in thumbnails display not correctly

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Gallery, defect)

Description

[(Inactive after June) George Duan [:gduan] [:喬智]]

Attachment: border doesn't fully cover the image

in HD device,

1. thumbnails border doesn't fully cover the image
2. when landscape mode, image doesn't fully fulfill the thumbnail

see attachments.

Comment 1

[(Inactive after June) George Duan [:gduan] [:喬智]]

Attachment: image cannot cover all thumbnail when landscape

image cannot cover all thumbnail when landscape

Comment 2

[(Inactive after June) George Duan [:gduan] [:喬智]]

Attachment: border.png

see image around the border, there's about 1px overlap another image

Comment 3

[(Inactive after June) George Duan [:gduan] [:喬智]]

Attachment: attach.html

1. px to rem
2. modify thumbnail background-size
3. modify outline-offset

Comment 4

[Wayne Chang [:wchang]]

HD+ UI bug

Comment 5

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Comment on attachment 782087 [details]
attach.html

1. and 3. are good to me.

2. doesn't happen on latest v1.1.0hd for me. I guess you saw that because those thumbnails
are generated by older version of MetadataParser.js, and didn't be cleaned. (i.e. by make
reset-gaia)

But thumbnails here are in fact blurred because we didn't take window.devicePixelRatio into
account when generating thumbnails. IMO what we really need to do here is to reflect
window.devicePixelRatio on generation thumbnails. In specific,
1) Multiply THUMBNAIL_WIDTH and THUMBNAIL_WIDTH by devicePixelRatio in MetadataParser.js.
2) use media query min-resolution (with dppx unit) to resize .thumbnail.

Anyway for this patch it's good for me with background-size in .thumbnails removed. Resizing every images to 100% violates its original design.

Comment 6

[(Inactive after June) George Duan [:gduan] [:喬智]]

Thanks Rex,
I decide to open bug 899526 for background-size problem.

Merged into 
master
https://github.com/mozilla-b2g/gaia/commit/64c856fa202abe57e6e5d71e7897906d5523ff1d
v1.1.0hd
https://github.com/mozilla-b2g/gaia/commit/06f462f7ca8e64acc5aceba5ecd39904c53a0dcf

Comment 7

[Al Tsai [:atsai]]

[2013/10/21 Helix Testing]
Gaia:     c829a2042594b6c3a4899ee27979799a0f301534
Gecko:    http://hg.mozilla.org/releases/mozilla-b2g18_v1_1_0_hd/rev/f7c657f6d019
BuildID   20131015042201
Version   18.0