898714 - land mercurial changes from beagle branch

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Aki Sasaki (not active)]

The mercurial.py changes here:
https://github.com/escapewindow/mozharness/compare/master...beagle

This should make the beagle patch easier to review.

Comment 1

[Aki Sasaki (not active)]

Attachment: mercurial

This is a simple one:

* only create parent_dir if parent dir (as opposed to os.path.exists(None))
* raise a VCSException if we fail to clone, rather than falling through and dying on the update

Comment 2

[Rail Aliiev [:rail]]

Comment on attachment 786078 [details] [diff] [review]
mercurial

Review of attachment 786078 [details] [diff] [review]:
-----------------------------------------------------------------

::: mozharness/base/vcs/mercurial.py
@@ +195,5 @@
>                  cmd.extend(['-b', branch])
>  
>          cmd.extend([repo, dest])
> +        if self.run_command(cmd, error_list=HgErrorList):
> +            raise VCSException("Unable to clone %s to %s!" % (repo, dest))

Can you use something like 

 if self.run_command(cmd, error_list=HgErrorList) != 0:

to improve readability?

Comment 3

[Aki Sasaki (not active)]

Comment on attachment 786078 [details] [diff] [review]
mercurial

https://hg.mozilla.org/build/mozharness/rev/b45675e93087