898716 - land virtualenv changes from beagle branch

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Aki Sasaki (not active)]

the python.py changes here:
https://github.com/escapewindow/mozharness/compare/master...beagle

This should make the beagle review go smoother.

Comment 1

[Aki Sasaki (not active)]

Attachment: virtualenv

This patch does two things:

* gets rid of the useless _check_existing_virtualenv() method.  I put this in place because I was having issues if I ran virtualenv calls while I had another virtualenv activated, but I think that was operator error.  I haven't seen those issues in recent memory.

* allows for virtualenv updates in create_virtualenv().

Basically, the existing create_virtualenv() will halt the script if the virtualenv already exists, which forces us to clobber the virtualenv and recreate it on every pass.

I found this to be the wrong behavior in my hg-git work, since the modules should change rarely, but I don't want to have to clobber everything to be able to update the module list in an automated way.

Comment 2

[Aki Sasaki (not active)]

Comment on attachment 786058 [details] [diff] [review]
virtualenv

https://hg.mozilla.org/build/mozharness/rev/ed24f8f7f554