898750 - EXCEPTION_ACCESS_VIOLATION in mozjs.dll

Status: VERIFIED FIXED

(Core :: JavaScript Engine, defect)

Description

[[e-mail]]

Attachment: mozilla.7z

User Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:25.0) Gecko/20100101 Firefox/25.0 (Beta/Release)
Build ID: 20130720172553

Steps to reproduce:

System environment:
Wes7 64bit
Visual Studio 2010 Express
Windows SDK 7.0A

my personal firefox builds my can’t start. they crash in mozjs.dll.

builds before bug 860965 are good. after  it lands, the build are bad.

Two js shell before and after this bug are attached.

Comment 1

[Shu-yu Guo [:shu]]

This doesn't show up on TBPL, so maybe it's something to do with Windows Embedded Standard.

I assume the shell crashes with an access violation as well. What about a non-threadsafe shell (configure without --enable-threadsafe)? Bug 860965 should only affect threadsafe shells.

Do you also happen to know the first bad revision from a bisection?

Comment 2

[[e-mail]]

the js shell are results of only SpiderMonkey Build. 
accoding to https://developer.mozilla.org/en-US/docs/SpiderMonkey/Build_Documentation , threadafe is not default option.

Acctually when I use vs2013 preview under windows 8.1 preview 64, I get the same results, then I use VS2010 under WES7.

builds at changeset 23dda916c3d0 (bug 860965 part1) are good, builds at changeset 3bdb29aa201e (bug 860965 part2) are bad.

Comment 3

[Shu-yu Guo [:shu]]

cset 3bdb29aa201e adds Array.build. I don't see how this can cause a crash on startup -- are you loading your own JavaScript that uses Array.build in some way?

Comment 4

[Shu-yu Guo [:shu]]

Ah, I see the problem. I accidentally put ArrayStaticBuild inside #ifdef ENABLE_PARALLEL_JS. In your build I bet that's not defined. I'll push a fix soon.

Comment 5

[Shu-yu Guo [:shu]]

Attachment: fix

Jack, could you see if this patch fixes the issue for you?

Comment 6

[Shu-yu Guo [:shu]]

Comment on attachment 782156 [details] [diff] [review]
fix

On second thought r=me for shell bustage.

Comment 7

[[e-mail]]

(In reply to Shu-yu Guo [:shu] from comment #5)
> Created attachment 782156 [details] [diff] [review]
> fix
> 
> Jack, could you see if this patch fixes the issue for you?

Yes, it works.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/823c58cdd723

Comment 9

[u279076]

Calling this verified fixed based on comment 7.