Closed Bug 898830 Opened 7 years ago Closed 6 years ago

Improve loading of show_bug.cgi

Categories

(Bugzilla :: Creating/Changing Bugs, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
Bugzilla 5.0

People

(Reporter: LpSolit, Assigned: LpSolit)

Details

(Keywords: perf)

Attachments

(2 files)

Attached patch patch, v1Splinter Review
While profiling show_bug.cgi, I managed to reduce its load time a bit by optimizing html_quote() and $user->groups_with_icon and by preloading the size of attachments. I also dropped |my $self = shift| in Attachment.pm to use $_[0] directly, as already in use in Bug.pm and Bugzilla.pm.
Attachment #782235 - Flags: review?(glob)
Attachment #782235 - Flags: review?(glob) → review?(sgreen)
Attachment #782235 - Flags: review?(sgreen) → review+
Flags: approval+
Flags: approval+ → approval?
Flags: approval? → approval+
Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/trunk/
modified Bugzilla/Attachment.pm
modified Bugzilla/User.pm
modified Bugzilla/Util.pm
Committed revision 8696.
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Oops, Oracle doesn't like 'size' as column alias. It's a reserved word, it looks like.

Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/trunk/
modified Bugzilla/Attachment.pm
Committed revision 8722.
You need to log in before you can comment on or make changes to this bug.