Closed Bug 898913 Opened 7 years ago Closed 7 years ago

"ASSERTION: no frame" and crash [@ nsHTMLReflowState::nsHTMLReflowState]

Categories

(Core :: Layout, defect, critical)

defect
Not set
critical

Tracking

()

RESOLVED FIXED
mozilla26

People

(Reporter: jruderman, Assigned: mats)

References

(Blocks 3 open bugs)

Details

(Keywords: assertion, crash, testcase)

Crash Data

Attachments

(3 files, 1 obsolete file)

###!!! ASSERTION: no frame: 'aFrame', file /Users/jruderman/trees/mozilla-central/layout/generic/nsHTMLReflowState.cpp, line 141
Attached file stack
Attached patch wip (obsolete) — Splinter Review
nsCSSFrameConstructor::RemoveFloatingFirstLetterFrames
fails to remove floating first-letter frames if they
are on the kPushedFloatsList.

https://tbpl.mozilla.org/?tree=Try&rev=3ac8205b26b8
https://tbpl.mozilla.org/?tree=Try&rev=441782474e94
Assignee: nobody → matspal
On Windows: bp-6729a098-93b5-4f45-a8e1-f1d492130729.
Crash Signature: [@ nsHTMLReflowState::nsHTMLReflowState(nsPresContext*, nsHTMLReflowState const&, nsIFrame*, nsSize const&, int, int, bool)]
OS: Mac OS X → All
Hardware: x86_64 → All
Attached patch fix+testSplinter Review
Look for the floating first-letter frame to remove on the kPushedFloatsList too.

https://tbpl.mozilla.org/?tree=Try&rev=cedd2002b079
https://tbpl.mozilla.org/?tree=Try&rev=c1e538f4acca
Attachment #782365 - Attachment is obsolete: true
Attachment #784620 - Flags: review?(dholbert)
Sorry for the delay on this - I was traveling for a good chunk of the last week, and this slipped off my radar.

Hoping to review this before I leave the office tonight.
Comment on attachment 784620 [details] [diff] [review]
fix+test

Seems reasonable.
Attachment #784620 - Flags: review?(dholbert) → review+
https://hg.mozilla.org/mozilla-central/rev/1efba891f53b
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
You need to log in before you can comment on or make changes to this bug.