898950 - [B2G][Helix][Gecko]Light sensor and proximity sensor does work on Helix.

Status: VERIFIED DUPLICATE of bug 827707

(Firefox OS Graveyard :: General, defect)

Description

[fang]

User Agent: Mozilla/4.0 (compatible; MSIE 8.0; Windows NT 6.1; Trident/4.0; SLCC2; .NET CLR 2.0.50727; .NET CLR 3.5.30729; .NET CLR 3.0.30729; Media Center PC 6.0; aff-kingsoft-ciba; .NET4.0C; .NET4.0E)

Steps to reproduce:

1. Make a voice call.
2. Block proximity sensor




Actual results:

Screen not switched off.


Expected results:

Screen switched off.

The light snesor does not work too, only G-sensor work well.
We have found the cause of this issue.
In "gecko\hal\gonk\GonkSensor.cpp", the code is as below:
      if (buffer[i].sensor >= size) {
                continue;
      }

The size id 3, sensor of lighe sensor is 4, sensor of proximity is 3, so the events of light sensor and proximity sensor are ignored.

Please help to resolve this in the next release, thanks!

Comment 1

[Wayne Chang [:wchang]]

Hi Viral,

can you check this and see if this should be corrected by oem or us?

Comment 2

[Wayne Chang [:wchang]]

Found the dupe to this. already fixed on master.

Comment 3

[William Hsu [:whsu]]

I still can reproduce this bug on following build.
I will test it again after the patch uplift to V1.1.0 HD
* Test build:(Mozilla-b2g18_v1_1_0_hd-helix/2013-08-12-04-22-03)
  + Mercurial-Information
    - Gecko revision="afd50da34b9f"
  + Git-information
    - Gaia revision="134356dc21d0627455f8bc536b140a18f39e20e9"

Comment 4

[William Hsu [:whsu]]

I cannot reproduce this bug on following build.
I will test it again after the patch uplift to V1.1.0 HD
* Test build:(Mozilla-b2g18_v1_1_0_hd-helix/2013-08-22-04-22-00)
  + Mercurial-Information
    - Gecko revision="84e2aa041c3c"
  + Git-information
    - Gaia revision="e3a6815b10080f9e257640cd068bf8efd86e04c7"

Marked as "Verified".