Closed Bug 899218 Opened 8 years ago Closed 8 years ago

Scratchpad doesn't handle long strings

Categories

(DevTools Graveyard :: Scratchpad, defect, P3)

defect

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 25

People

(Reporter: bbenvie, Assigned: bbenvie)

Details

Attachments

(1 file, 2 obsolete files)

No description provided.
Attached patch WIP1 (obsolete) — Splinter Review
Adds Scratchpad._writePrimitiveAsComment which will print primitives and resolve long strings. Still need to add a test.
Assignee: nobody → bbenvie
Status: NEW → ASSIGNED
Priority: -- → P3
Attached patch WIP2 (obsolete) — Splinter Review
Add a test.
Attachment #782787 - Attachment is obsolete: true
Attachment #783399 - Flags: review?(rcampbell)
Comment on attachment 783399 [details] [diff] [review]
WIP2

Review of attachment 783399 [details] [diff] [review]:
-----------------------------------------------------------------

you should change the name of your test to not include the bug number. Those are gross.

r+ with that change.
Attachment #783399 - Flags: review?(rcampbell) → review+
Attached patch WIP3Splinter Review
Rename test.
Attachment #783399 - Attachment is obsolete: true
https://hg.mozilla.org/mozilla-central/rev/6f9c07973a39
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 25
Product: Firefox → DevTools
Product: DevTools → DevTools Graveyard
You need to log in before you can comment on or make changes to this bug.