Status
()
People
(Reporter: bholley, Assigned: bholley)
Tracking
Bug Flags:
Firefox Tracking Flags
(Not tracked)
Details
Attachments
(3 attachments)
13.32 KB,
patch
|
luke
:
review+
|
Details | Diff | Splinter Review |
16.74 KB,
patch
|
luke
:
review+
|
Details | Diff | Splinter Review |
69.67 KB,
patch
|
luke
:
review+
|
Details | Diff | Splinter Review |
Now that JS_GetGlobalObject is gone, the naming could use some improvement.
(Assignee) | ||
Comment 1•5 years ago
|
||
Created attachment 782772 [details] [diff] [review] Part 1 - Rename js::GetDefaultGlobalForContext to js::GetDefaultObjectForContext. v1 This is more correct, since the object very often is not a global.
Attachment #782772 -
Flags: review?(luke)
(Assignee) | ||
Comment 2•5 years ago
|
||
Created attachment 782773 [details] [diff] [review] Part 2 - Rename JS_SetGlobalObject and move it into jsfriendapi. v1
Attachment #782773 -
Flags: review?(luke)
(Assignee) | ||
Comment 3•5 years ago
|
||
Created attachment 782774 [details] [diff] [review] Part 3 - Rename JS_GetGlobalForScopeChain to JS::CurrentGlobalOrNull. v1 This was done with perl/grep.
Attachment #782774 -
Flags: review?(luke)
![]() |
||
Comment 4•5 years ago
|
||
Comment on attachment 782772 [details] [diff] [review] Part 1 - Rename js::GetDefaultGlobalForContext to js::GetDefaultObjectForContext. v1 By the previous reasoning on irc, how about naming this js::DefaultObjectForContextOrNull?
Attachment #782772 -
Flags: review?(luke) → review+
![]() |
||
Updated•5 years ago
|
Attachment #782773 -
Flags: review?(luke) → review+
![]() |
||
Updated•5 years ago
|
Attachment #782774 -
Flags: review?(luke) → review+
(Assignee) | ||
Comment 5•5 years ago
|
||
remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/e5305a6fba38 remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/829fcfef0810 remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/d19b33105ded
![]() |
||
Comment 6•5 years ago
|
||
Courtesy typo fix: https://hg.mozilla.org/integration/mozilla-inbound/rev/82f0ca76c24f
![]() |
||
Comment 7•5 years ago
|
||
Oops, I should have looked closer before pushing the typo fix: the patch with the bustage clearly intended to replace all the JS_GetGlobalForScopeChain with JS::CurrentGlobalOrNull, so the s/js::/JS::/ fix in comment 6 was wrong. https://hg.mozilla.org/integration/mozilla-inbound/rev/5d56f5be9d3f Nice job glandium for noticing!
(Assignee) | ||
Comment 8•5 years ago
|
||
(In reply to Luke Wagner [:luke] from comment #7) > Nice job glandium for noticing! Nice catch! the js/ipc thing came up while rebasing right before pushing, so I must have messed it up.
Comment 9•5 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/e5305a6fba38 https://hg.mozilla.org/mozilla-central/rev/829fcfef0810 https://hg.mozilla.org/mozilla-central/rev/d19b33105ded https://hg.mozilla.org/mozilla-central/rev/82f0ca76c24f https://hg.mozilla.org/mozilla-central/rev/5d56f5be9d3f
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
You need to log in
before you can comment on or make changes to this bug.
Description
•