899245 - Rename JSAPI global object accessors

Status: RESOLVED FIXED

(Core :: XPConnect, defect)

Description

[Bobby Holley (On Leave Through ~December)]

Now that JS_GetGlobalObject is gone, the naming could use some improvement.

Comment 1

[Bobby Holley (On Leave Through ~December)]

Attachment: Part 1 - Rename js::GetDefaultGlobalForContext to js::GetDefaultObjectForContext. v1

This is more correct, since the object very often is not a global.

Comment 2

[Bobby Holley (On Leave Through ~December)]

Attachment: Part 2 - Rename JS_SetGlobalObject and move it into jsfriendapi. v1

Comment 3

[Bobby Holley (On Leave Through ~December)]

Attachment: Part 3 - Rename JS_GetGlobalForScopeChain to JS::CurrentGlobalOrNull. v1

This was done with perl/grep.

Comment 4

[Luke Wagner [:luke]]

Comment on attachment 782772 [details] [diff] [review]
Part 1 - Rename js::GetDefaultGlobalForContext to js::GetDefaultObjectForContext. v1

By the previous reasoning on irc, how about naming this js::DefaultObjectForContextOrNull?

Comment 5

[Bobby Holley (On Leave Through ~December)]

remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/e5305a6fba38
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/829fcfef0810
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/d19b33105ded

Comment 6

[Luke Wagner [:luke]]

Courtesy typo fix:
https://hg.mozilla.org/integration/mozilla-inbound/rev/82f0ca76c24f

Comment 7

[Luke Wagner [:luke]]

Oops, I should have looked closer before pushing the typo fix: the patch with the bustage clearly intended to replace all the JS_GetGlobalForScopeChain with JS::CurrentGlobalOrNull, so the s/js::/JS::/ fix in comment 6 was wrong.

https://hg.mozilla.org/integration/mozilla-inbound/rev/5d56f5be9d3f

Nice job glandium for noticing!

Comment 8

[Bobby Holley (On Leave Through ~December)]

(In reply to Luke Wagner [:luke] from comment #7)
> Nice job glandium for noticing!

Nice catch! the js/ipc thing came up while rebasing right before pushing, so I must have messed it up.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/e5305a6fba38
https://hg.mozilla.org/mozilla-central/rev/829fcfef0810
https://hg.mozilla.org/mozilla-central/rev/d19b33105ded
https://hg.mozilla.org/mozilla-central/rev/82f0ca76c24f
https://hg.mozilla.org/mozilla-central/rev/5d56f5be9d3f