899274 - Update test_manifest_and_tests_exclusive.py with correct argument path values

Status: RESOLVED FIXED

(Testing Graveyard :: Mozmill, defect)

Description

[Jonathan French (:jfrench)]

I think this squeaked by me/us during review. The argument paths for mutt/mutt/tests/python/cli test_manifest_and_tests_exclusive.py appear to be an earlier iteration of the review and not the final ones from the landed patch. Interestingly they didn't fail during the test runs, or otherwise make themselves known.

This bug will fix them.

The original commit was this, for reference
https://github.com/mozilla/mozmill/commit/7a98161d79450b1973c1b51907de056e109d62a7

test_manifest_and_tests_exclusive.py corrections:
js-tests -> js-modules
test_module1.js -> useMozmill/testUseMozmillTestPass.js** -> testTestPass.js
test-null.ini -> manifest-empty.ini

** this file above was replaced in this later commit below, by testTestPass.js. So is what I believe it needs to be at this time.
https://github.com/mozilla/mozmill/commit/31daf5f982c17c9a58bb758a501fffe4f2b535fd

Comment 1

[Jonathan French (:jfrench)]

Attachment: update correct path values (master) rev1.0

Patch "update correct path values (master) rev1.0" for Master branch. One file modified.

This patch contains corrections described in Comment 1.

Tests run as `mutt -m .../cli/manifest.ini` with patch produce the same results as clean master.

Tested in:
Windows XP32 SP3
mozmill-env w/mozmill 2.0rc4 latest + patch rev1.0
latest Nightly 25.0a1 20130729030214 140267

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2] (away July 24th - August 16th)]

Comment on attachment 782775 [details] [diff] [review]
update correct path values (master) rev1.0

Review of attachment 782775 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. Thanks Jonathan!

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2] (away July 24th - August 16th)]

Landed on master:
https://github.com/mozilla/mozmill/commit/a241775b4104e6051f26d2201df00af1040d7605