Add a localization comment to contextmenu.search

RESOLVED FIXED in Firefox 25

Status

()

Firefox for Android
Text Selection
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: flod, Assigned: ckitching)

Tracking

25 Branch
Firefox 25
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

4 years ago
Bug 828254 added this string

contextmenu.search=%S Search

Please add a localization comment explaining what %S is. For example something like

# LOCALIZATION NOTE (contextmenu.search): %S is the name of the search engine
# used to search for the highlighted text

Comment 1

4 years ago
Sorry, flod, I should have caught that.

Chris, let's make sure we land this before the Aurora merge.
Assignee: nobody → ckitching
(Assignee)

Comment 2

4 years ago
Created attachment 783370 [details] [diff] [review]
localisationComment.patch

Eek! Sorry about that. Another convention learned...
Attachment #783370 - Flags: review?(margaret.leibovic)
(Assignee)

Updated

4 years ago
Status: NEW → ASSIGNED

Comment 3

4 years ago
Comment on attachment 783370 [details] [diff] [review]
localisationComment.patch

Review of attachment 783370 [details] [diff] [review]:
-----------------------------------------------------------------

Nice, thanks! Not your fault, I should have caught this. Also, we should try to be better in general about adding localization notes.
Attachment #783370 - Flags: review?(margaret.leibovic) → review+

Updated

4 years ago
Keywords: checkin-needed
https://hg.mozilla.org/integration/fx-team/rev/eb6f884142fc
Flags: in-testsuite-
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/eb6f884142fc
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 25
You need to log in before you can comment on or make changes to this bug.