Last Comment Bug 899440 - Add a localization comment to
: Add a localization comment to
Product: Firefox for Android
Classification: Client Software
Component: Text Selection (show other bugs)
: 25 Branch
: All All
-- normal (vote)
: Firefox 25
Assigned To: Chris Kitching [:ckitching]
Depends on:
Blocks: 828254
  Show dependency treegraph
Reported: 2013-07-29 23:12 PDT by Francesco Lodolo [:flod]
Modified: 2013-07-31 06:08 PDT (History)
3 users (show)
MattN+bmo: in‑testsuite-
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

localisationComment.patch (1.39 KB, patch)
2013-07-30 14:53 PDT, Chris Kitching [:ckitching]
margaret.leibovic: review+
Details | Diff | Splinter Review

Description User image Francesco Lodolo [:flod] 2013-07-29 23:12:53 PDT
Bug 828254 added this string Search

Please add a localization comment explaining what %S is. For example something like

# LOCALIZATION NOTE ( %S is the name of the search engine
# used to search for the highlighted text
Comment 1 User image :Margaret Leibovic 2013-07-30 10:02:35 PDT
Sorry, flod, I should have caught that.

Chris, let's make sure we land this before the Aurora merge.
Comment 2 User image Chris Kitching [:ckitching] 2013-07-30 14:53:10 PDT
Created attachment 783370 [details] [diff] [review]

Eek! Sorry about that. Another convention learned...
Comment 3 User image :Margaret Leibovic 2013-07-30 15:03:30 PDT
Comment on attachment 783370 [details] [diff] [review]

Review of attachment 783370 [details] [diff] [review]:

Nice, thanks! Not your fault, I should have caught this. Also, we should try to be better in general about adding localization notes.
Comment 4 User image Matthew N. [:MattN] (PM if requests are blocking you) 2013-07-30 18:50:05 PDT
Comment 5 User image Ed Morley [:emorley] 2013-07-31 05:21:15 PDT

Note You need to log in before you can comment on or make changes to this bug.