Last Comment Bug 899440 - Add a localization comment to contextmenu.search
: Add a localization comment to contextmenu.search
Status: RESOLVED FIXED
:
Product: Firefox for Android
Classification: Client Software
Component: Text Selection (show other bugs)
: 25 Branch
: All All
: -- normal (vote)
: Firefox 25
Assigned To: Chris Kitching [:ckitching]
:
Mentors:
Depends on:
Blocks: 828254
  Show dependency treegraph
 
Reported: 2013-07-29 23:12 PDT by Francesco Lodolo [:flod]
Modified: 2013-07-31 06:08 PDT (History)
3 users (show)
MattN+bmo: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
localisationComment.patch (1.39 KB, patch)
2013-07-30 14:53 PDT, Chris Kitching [:ckitching]
margaret.leibovic: review+
Details | Diff | Splinter Review

Description Francesco Lodolo [:flod] 2013-07-29 23:12:53 PDT
Bug 828254 added this string

contextmenu.search=%S Search

Please add a localization comment explaining what %S is. For example something like

# LOCALIZATION NOTE (contextmenu.search): %S is the name of the search engine
# used to search for the highlighted text
Comment 1 :Margaret Leibovic 2013-07-30 10:02:35 PDT
Sorry, flod, I should have caught that.

Chris, let's make sure we land this before the Aurora merge.
Comment 2 Chris Kitching [:ckitching] 2013-07-30 14:53:10 PDT
Created attachment 783370 [details] [diff] [review]
localisationComment.patch

Eek! Sorry about that. Another convention learned...
Comment 3 :Margaret Leibovic 2013-07-30 15:03:30 PDT
Comment on attachment 783370 [details] [diff] [review]
localisationComment.patch

Review of attachment 783370 [details] [diff] [review]:
-----------------------------------------------------------------

Nice, thanks! Not your fault, I should have caught this. Also, we should try to be better in general about adding localization notes.
Comment 4 Matthew N. [:MattN] 2013-07-30 18:50:05 PDT
https://hg.mozilla.org/integration/fx-team/rev/eb6f884142fc
Comment 5 Ed Morley [:emorley] 2013-07-31 05:21:15 PDT
https://hg.mozilla.org/mozilla-central/rev/eb6f884142fc

Note You need to log in before you can comment on or make changes to this bug.