Closed Bug 899492 Opened 7 years ago Closed 7 years ago

Mochitest browser_pluginCrashCommentAndURL.js fails when the crash reporter is disabled

Categories

(Core :: Plug-ins, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla25

People

(Reporter: decoder, Assigned: decoder)

References

(Blocks 1 open bug)

Details

(Keywords: sec-want, Whiteboard: [asan-test-failure])

Attachments

(1 file)

The mentioned test is failing on ASan tests, so I took a look at the content:

>  // The test harness sets MOZ_CRASHREPORTER_NO_REPORT, which disables plugin
>  // crash reports.  This test needs them enabled.  The test also needs a mock
>  // report server, and fortunately one is already set up by toolkit/
>  // crashreporter/test/Makefile.in.  Assign its URL to MOZ_CRASHREPORTER_URL,
>  // which CrashSubmit.jsm uses as a server override.

I assume that means it should actually be disabled when we build with --disable-crashreporter. I'll create a patch that guards this file with MOZ_CRASHREPORTER.
(In reply to Christian Holler (:decoder) from comment #0)
> I assume that means it should actually be disabled when we build with
> --disable-crashreporter. I'll create a patch that guards this file with
> MOZ_CRASHREPORTER.

That sounds right - the other plugin crash & hang test in dom/plugins already do this:
http://hg.mozilla.org/mozilla-central/annotate/3d40d270c031/dom/plugins/test/mochitest/Makefile.in#l129
Attached patch PatchSplinter Review
Assignee: nobody → choller
Status: NEW → ASSIGNED
Attachment #783120 - Flags: review?(ted)
Attachment #783120 - Flags: review?(ted) → review+
https://hg.mozilla.org/mozilla-central/rev/7cedf63952be
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
You need to log in before you can comment on or make changes to this bug.