899492 - Mochitest browser_pluginCrashCommentAndURL.js fails when the crash reporter is disabled

Status: RESOLVED FIXED

(Core Graveyard :: Plug-ins, defect)

Description

[Christian Holler (:decoder)]

The mentioned test is failing on ASan tests, so I took a look at the content:

>  // The test harness sets MOZ_CRASHREPORTER_NO_REPORT, which disables plugin
>  // crash reports.  This test needs them enabled.  The test also needs a mock
>  // report server, and fortunately one is already set up by toolkit/
>  // crashreporter/test/Makefile.in.  Assign its URL to MOZ_CRASHREPORTER_URL,
>  // which CrashSubmit.jsm uses as a server override.

I assume that means it should actually be disabled when we build with --disable-crashreporter. I'll create a patch that guards this file with MOZ_CRASHREPORTER.

Comment 1

[Georg Fritzsche [:gfritzsche]]

(In reply to Christian Holler (:decoder) from comment #0)
> I assume that means it should actually be disabled when we build with
> --disable-crashreporter. I'll create a patch that guards this file with
> MOZ_CRASHREPORTER.

That sounds right - the other plugin crash & hang test in dom/plugins already do this:
http://hg.mozilla.org/mozilla-central/annotate/3d40d270c031/dom/plugins/test/mochitest/Makefile.in#l129

Comment 2

[Christian Holler (:decoder)]

Attachment: Patch

Comment 3

[Christian Holler (:decoder)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7cedf63952be

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/7cedf63952be