Closed Bug 899695 Opened 11 years ago Closed 11 years ago

"mach python" fails on Windows with TypeError: environment can only contain strings

Categories

(Testing :: General, defect)

25 Branch
All
Windows 8
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla26

People

(Reporter: mbrubeck, Assigned: mbrubeck)

References

Details

(Keywords: regression)

Attachments

(2 files, 1 obsolete file)

Attached patch env-str (obsolete) — Splinter Review
Similar to bug 810435 and bug 840588 comment 18; there's a bug in at least some versions of Python where subprocess.py does not like Unicode strings.  I had thought this was fixed in Python 2.7.3 and later, but I'm seeing this error in Python 2.7.4 from the current mozilla-build.  :(
Attachment #783263 - Flags: review?(gps)
Comment on attachment 783263 [details] [diff] [review]
env-str

Review of attachment 783263 [details] [diff] [review]:
-----------------------------------------------------------------

This should have been fixed in Python 2.7.3! There are patch conflicts with bug 898903. This patch appears to be a superset. You should work things out with actors in the other bug then reflag me for review of the mach bits.
Attachment #783263 - Flags: review?(gps)
Attached patch patch v2Splinter Review
Same as above but dropped the fixes that already landed in bug 898903.

(In reply to Gregory Szorc [:gps] from comment #1)
> This should have been fixed in Python 2.7.3!

I had thought so too, but now I'm not sure who told me that or why.  I don't see any indication this is reported as a Python bug, or is even a bug rather than a by-design limitation.
Attachment #783263 - Attachment is obsolete: true
Attachment #783484 - Flags: review?(gps)
Summary: "mach mochitest-* path" and "mach python" fail on Windows with TypeError: environment can only contain strings → "mach python" fails on Windows with TypeError: environment can only contain strings
Comment on attachment 783484 [details] [diff] [review]
patch v2

Review of attachment 783484 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.
Attachment #783484 - Flags: review?(gps) → review+
https://hg.mozilla.org/mozilla-central/rev/3fc5338cc5b1
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
You need to log in before you can comment on or make changes to this bug.