899735 - IonMonkey: Add a function to the shell that makes it possible to bail in IM

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Hannes Verschore [:h4writer]]

In bug 891910 I disable a "common" way to bailout. This is needed for some testcases. So I'm adding a bailout() function in the shell for this.

Comment 1

[Hannes Verschore [:h4writer]]

Attachment: bug899735-bail-func

Comment 2

[Nicolas B. Pierron [:nbp]]

Comment on attachment 783314 [details] [diff] [review]
bug899735-bail-func

Review of attachment 783314 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

Comment 3

[Jan de Mooij [:jandem]]

Comment on attachment 783314 [details] [diff] [review]
bug899735-bail-func

Review of attachment 783314 [details] [diff] [review]:
-----------------------------------------------------------------

Nice.

::: js/src/ion/LIR-Common.h
@@ +1022,5 @@
> +  public:
> +    LIR_HEADER(Bail)
> +
> +    LBail()
> +    { }

Nit: can remove the empty constructor.

::: js/src/ion/MIR.h
@@ +1570,5 @@
> +class MBail : public MNullaryInstruction
> +{
> +  protected:
> +    MBail()
> +    { }

Nit: this instruction is effectful so won't be removed, but maybe call setGuard(); just to make sure it won't be removed when somebody marks it as non-effectful (we should probably do this now by overriding getAliasSet).

Comment 4

[Hannes Verschore [:h4writer]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8d0d262985d9

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/8d0d262985d9