Closed
Bug 899801
Opened 11 years ago
Closed 11 years ago
BrowserElementPanning's KineticPanning.momentums can have over 20,000 elements in it
Categories
(Firefox OS Graveyard :: General, defect)
Tracking
(blocking-b2g:leo+, firefox23 wontfix, firefox24 wontfix, firefox25 fixed, b2g18 fixed, b2g18-v1.0.0 wontfix, b2g18-v1.0.1 wontfix, b2g-v1.1hd fixed)
People
(Reporter: mccr8, Assigned: justin.lebar+bug)
References
Details
(Whiteboard: [MemShrink][LeoVB+])
Attachments
(1 file)
|
1.77 KB,
patch
|
vingtetun
:
review+
|
Details | Diff | Splinter Review |
In bug 898990, leo has a test that just opens an app every 10 seconds. After doing this for 3 or 4 days, Olli noticed that KineticPanning.momentums from BrowserElementPanning has over 20,000 things in it. This shouldn't cause long CC times, which is what that bug was about, but it still seems bad.
|
Reporter | |
Updated•11 years ago
|
Summary: KineticPanning.momentums can have over 20,000 elements in it → BrowserElementPanning's KineticPanning.momentums can have over 20,000 elements in it
|
Assignee | |
Updated•11 years ago
|
Assignee: nobody → justin.lebar+bug
|
|
Assignee | |
Comment 1•11 years ago
|
||
I'm testing a patch.
|
|
Assignee | |
Comment 2•11 years ago
|
||
Attachment #783432 -
Flags: review?(21)
|
||
Comment 3•11 years ago
|
||
Comment on attachment 783432 [details] [diff] [review] Patch, v1: Don't keep more than five "momentums" values in BrowserElementPanning.js. Review of attachment 783432 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/browser-element/BrowserElementPanning.js @@ +644,1 @@ > momentums = momentums.slice(-kSamples); I think that you don't need this shallow copy anymore if you ensure that momemtums.length <= kSamples in record().
|
||
Comment 4•11 years ago
|
||
Comment on attachment 783432 [details] [diff] [review] Patch, v1: Don't keep more than five "momentums" values in BrowserElementPanning.js. r+ with Fabrice suggestion.
Attachment #783432 -
Flags: review?(21) → review+
|
|
Assignee | |
Comment 6•11 years ago
|
||
Thanks, guys. https://hg.mozilla.org/integration/mozilla-inbound/rev/7f01c4bb30e6
https://hg.mozilla.org/mozilla-central/rev/7f01c4bb30e6
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
|
||
Comment 8•11 years ago
|
||
https://hg.mozilla.org/releases/mozilla-b2g18/rev/90b792959f01
status-b2g18:
--- → fixed
status-b2g18-v1.0.0:
--- → wontfix
status-b2g18-v1.0.1:
--- → wontfix
status-b2g-v1.1hd:
--- → affected
status-firefox23:
--- → wontfix
status-firefox24:
--- → wontfix
status-firefox25:
--- → fixed
Target Milestone: --- → 1.1 QE5
|
||
Updated•11 years ago
|
Whiteboard: [MemShrink] → [MemShrink][LeoVB+]
|
|
||
Comment 9•11 years ago
|
||
Apparently I forgot to mark this bug when it landed on the v1.1hd branch. My apologies. https://hg.mozilla.org/releases/mozilla-b2g18_v1_1_0_hd/rev/90b792959f01
You need to log in
before you can comment on or make changes to this bug.
Description
•