899801 - BrowserElementPanning's KineticPanning.momentums can have over 20,000 elements in it

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[Andrew McCreight [:mccr8]]

In bug 898990, leo has a test that just opens an app every 10 seconds.  After doing this for 3 or 4 days, Olli noticed that KineticPanning.momentums from BrowserElementPanning has over 20,000 things in it.  This shouldn't cause long CC times, which is what that bug was about, but it still seems bad.

Comment 1

[Justin Lebar (not reading bugmail)]

I'm testing a patch.

Comment 2

[Justin Lebar (not reading bugmail)]

Attachment: Patch, v1: Don't keep more than five "momentums" values in BrowserElementPanning.js.

Comment 3

[[:fabrice] Fabrice Desré]

Comment on attachment 783432 [details] [diff] [review]
Patch, v1: Don't keep more than five "momentums" values in BrowserElementPanning.js.

Review of attachment 783432 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/browser-element/BrowserElementPanning.js
@@ +644,1 @@
>      momentums = momentums.slice(-kSamples);

I think that you don't need this shallow copy anymore if you ensure that momemtums.length <= kSamples in record().

Comment 4

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 783432 [details] [diff] [review]
Patch, v1: Don't keep more than five "momentums" values in BrowserElementPanning.js.

r+ with Fabrice suggestion.

Comment 5

[Justin Lebar (not reading bugmail)]

Blocks a blocker.

Comment 6

[Justin Lebar (not reading bugmail)]

Thanks, guys.

https://hg.mozilla.org/integration/mozilla-inbound/rev/7f01c4bb30e6

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/7f01c4bb30e6

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g18/rev/90b792959f01

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Apparently I forgot to mark this bug when it landed on the v1.1hd branch. My apologies.
https://hg.mozilla.org/releases/mozilla-b2g18_v1_1_0_hd/rev/90b792959f01