Closed
Bug 899818
Opened 12 years ago
Closed 12 years ago
mach setup wizard is quoting string values
Categories
(Firefox Build System :: Mach Core, enhancement)
Firefox Build System
Mach Core
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla25
People
(Reporter: gps, Assigned: gps)
References
Details
Attachments
(1 file)
|
1.30 KB,
patch
|
Gijs
:
review+
|
Details | Diff | Splinter Review |
As reported in bug 794580 comment #45. I think the fix is trivial.
|
Assignee | |
Comment 1•12 years ago
|
||
Please r+ if this fixes the quoting problem. (This code has no module,
so you can review it.)
Attachment #783412 -
Flags: review?(gijskruitbosch+bugs)
|
|
Assignee | |
Updated•12 years ago
|
Assignee: nobody → gps
|
||
Comment 2•12 years ago
|
||
Comment on attachment 783412 [details] [diff] [review]
Don't add quotes to values when writing Mercurial configs
Review of attachment 783412 [details] [diff] [review]:
-----------------------------------------------------------------
This fixes it for me --> r+
Attachment #783412 -
Flags: review?(gijskruitbosch+bugs) → review+
|
|
Assignee | |
Comment 3•12 years ago
|
||
Flags: in-testsuite-
|
||
Comment 4•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
|
||
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•