mach setup wizard is quoting string values

RESOLVED FIXED in mozilla25

Status

Firefox Build System
Mach Core
RESOLVED FIXED
5 years ago
3 months ago

People

(Reporter: gps, Assigned: gps)

Tracking

Trunk
mozilla25

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
As reported in bug 794580 comment #45. I think the fix is trivial.
(Assignee)

Comment 1

5 years ago
Created attachment 783412 [details] [diff] [review]
Don't add quotes to values when writing Mercurial configs

Please r+ if this fixes the quoting problem. (This code has no module,
so you can review it.)
Attachment #783412 - Flags: review?(gijskruitbosch+bugs)
(Assignee)

Updated

5 years ago
Assignee: nobody → gps
Comment on attachment 783412 [details] [diff] [review]
Don't add quotes to values when writing Mercurial configs

Review of attachment 783412 [details] [diff] [review]:
-----------------------------------------------------------------

This fixes it for me --> r+
Attachment #783412 - Flags: review?(gijskruitbosch+bugs) → review+

Comment 4

5 years ago
https://hg.mozilla.org/mozilla-central/rev/5aab1bae4fb4
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25

Updated

3 months ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.