899837 - /existing page and "Thank you for updating your email preferences"

Status: VERIFIED FIXED

(www.mozilla.org :: Newsletters, defect)

Description

[Jessilyn Davis]

https://www.mozilla.org/en-US/newsletter/updated/ has 3 different content versions:

1) Go directly to:  https://www.mozilla.org/en-US/newsletter/updated/ and see no message custom message above "While here, why not check out some more Firefox awesomeness." content box.

2) Go to /existing, update your email preferences, and see above existing content box a message of "Thank you for updating your email preferences." 


3) Go to /existing, unsubscribe all -> be taken to page that has survey (with message showing up top for "Thank you for updating your email preferences.") - submit survey, and then see "You've been unsubscribed...we're sorry to see you go"


This is cool - but we need to be able to update scenario #1 to have the message of "Thank you for updating your email preferences." all the time (like the l10n pages of this page on php & like #2 currently looks).

We need this page updated before we can launch our re-engagement campaign - is it possible to make this live by Aug 6th?

Comment 1

[Jessilyn Davis]

Attachment: Scenario 1

Comment 2

[Jessilyn Davis]

Attachment: Scenario 2

Comment 3

[Jessilyn Davis]

Attachment: Scenario 3

Comment 4

[Dan Poirier [:dpoirier]]

Technically, "Thank you for updating your email preferences." isn't part of that page. It's a one-time message from the /existing page when you submit it, that is just shown at the top of whatever your next page is.  The next page will always be /updated in this case, though.

We can easily enough change the /updated page to just always say that at the top. Shall we do that?

Comment 5

[Jessilyn Davis]

Attachment: Scenario pre3

Comment 6

[Jessilyn Davis]

Sweet - let's roll with the easily enough option of changing the /updated page to always say "Thank you for updating your email preferences" at the top.


Thanks!

Comment 7

[Dan Poirier [:dpoirier]]

Pull request https://github.com/mozilla/bedrock/pull/1121

Comment 8

[Jessilyn Davis]

Checking in on this - when will this be somewhere to test? And when can we push it live?

Comment 9

[Dan Poirier [:dpoirier]]

The code changes are ready for review at  https://github.com/mozilla/bedrock/pull/1121.  Once they're merged, it should be ready to test shortly at www-dev.allizom.org.

Comment 10

[[github robot]]

Commits pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/8e11698661e03fc53ed0796e351f3694315a8a6b
Bug 899837 - Always display thanks on /updated page

Always display "Thank you for updating your email preferences"
at the top of the /newsletter/updated/ page.

https://github.com/mozilla/bedrock/commit/41524a31ae3408091bce0d773b8c3fcf8356c727
Merge pull request #1121 from dpoirier/bug-899837-updated-thanks

Bug 899837 - Always display thanks on /updated page

Comment 11

[Jessilyn Davis]

Attachment: Screen Shot 2013-08-06 at 12.04.26 PM.png

https://www-dev.allizom.org/en-US/newsletter/updated/ still doesn't have the message always showing.

Comment 12

[Jessilyn Davis]

Attachment: Future scenario to fix

Looks good on dev!

In the future we'll want to change the behavior after the global unsubscribe (see attachment), but for now, this is okay.

Let me know when this goes to prod.

Thanks!

Comment 13

[Dan Poirier [:dpoirier]]

Comment on attachment 786469 [details]
Future scenario to fix

We could change it to not add the "Thank you" message in these two cases:

* user has "unsubscribed all" and we're asking if they want to say why
* user has told us why they unsubscribed all (the scenario in the screenshot)

How about that?

Comment 14

[Dan Poirier [:dpoirier]]

(In reply to Dan Poirier [:dpoirier] from comment #13)

> We could change it to not add the "Thank you" message in these two cases:
> 
> * user has "unsubscribed all" and we're asking if they want to say why
> * user has told us why they unsubscribed all (the scenario in the screenshot)
> 
> How about that?

If that's what we want, I went ahead and opened a PR to implement it, https://github.com/mozilla/bedrock/pull/1138

Comment 15

[[github robot]]

Commits pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/f42b62c3a8ed9c4448dd16ec056dbc72f39563c0
Bug 899837 - Don't always say thanks on newsletter/updated

Only say thanks on newsletter/updated page if the page isn't
already saying something more specific, like "We're sorry
to see you go" or "Thanks for telling us why you're leaving".

https://github.com/mozilla/bedrock/commit/bd03bc933308dad69dd01e704aaba9da65c48393
Merge pull request #1138 from dpoirier/bug-899837-tweak-newsletter-updated-thanks

Bug 899837 - Don't always say thanks on newsletter/updated

Comment 16

[Jessilyn Davis]

Dan - I love this solution. I just checked: https://www-dev.allizom.org/  and I don't see the changes there yet. Let me know when it's available to take a peek.

Thanks!

Comment 17

[Jessilyn Davis]

This looks great on stage (minus basket not working).

Push to prod if we're not worried about basket.

Comment 18

[Dan Poirier [:dpoirier]]

There were no basket changes, so if basket's not working, it must be something else.

Comment 19

[Jessilyn Davis]

Pmac said that the basket version on stage isn't the latest basket. As long as the basket on prod isn't reverted to an old/not working version - I think we're good to push to prod. 

Is it possible to push this live today?

Comment 20

[Jessilyn Davis]

It looks like this went live and basket is working as expected.

Closing this out.

Thanks!

Comment 21

[[github robot]]

Commit pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/ee3278135a4868e3d32a2d1555fd20cc745b78e9
Remove duplicate messages from /newsletter/existing

The template for /existing displayed the Django messages so we could
tell the user when their token was bad or other errors occurred.

In bug 899837, we changed the base template to display Django messages,
resulting in the /existing page showing the messages twice.

Remove the display of messages from the /existing page's template so
we only see the messages once, via the base template.

Comment 22

[Jessilyn Davis]

(In reply to [github robot] from comment #21)
> Commit pushed to master at https://github.com/mozilla/bedrock
> 
> https://github.com/mozilla/bedrock/commit/
> ee3278135a4868e3d32a2d1555fd20cc745b78e9
> Remove duplicate messages from /newsletter/existing

With this push, are we reverting the changes that allowed: https://www.mozilla.org/en-US/newsletter/updated/  to show the "Thank you for updating your email preferences." at all times?

Comment 23

[Dan Poirier [:dpoirier]]

No, this does not revert the changes that allowed: https://www.mozilla.org/en-US/newsletter/updated/  to show the "Thank you for updating your email preferences." at all times.

Comment 24

[Jessilyn Davis]

\o/ thanks.